From: David Disseldorp <ddiss@suse.de>
To: Zorro Lang <zlang@redhat.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>, fstests@vger.kernel.org
Subject: Re: [PATCH v3] tests: _fail on _scratch_mkfs_sized failure
Date: Tue, 30 Apr 2024 10:25:02 +1000 [thread overview]
Message-ID: <20240430102502.3167c16a@echidna> (raw)
In-Reply-To: <20240429190244.lr2xg74pzk2erwji@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Tue, 30 Apr 2024 03:02:44 +0800, Zorro Lang wrote:
> On Mon, Apr 29, 2024 at 09:05:16AM -0700, Darrick J. Wong wrote:
...
> > > +_scratch_mkfs_sized()
> > > +{
> > > + _try_scratch_mkfs_sized $* || _fail "_scratch_mkfs_sized (size=${1}) failed"
> >
> > I wonder if you ought to dump all the arguments, but the maintainer did
> > say to print the *size*. :)
>
> Sorry I didn't say that clearly, I mean the arguments related with size :-D
No worries :) I'm fine with it either way.
>
> If both of you don't have more suggestions, I can help to change this line to:
>
> _try_scratch_mkfs_sized $* || \
> _fail "_scratch_mkfs_sized failed with ($*)"
>
> when I merge it.
Sure, works for me.
Cheers, David
prev parent reply other threads:[~2024-04-30 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 15:37 [PATCH v3] tests: _fail on _scratch_mkfs_sized failure David Disseldorp
2024-04-29 16:05 ` Darrick J. Wong
2024-04-29 19:02 ` Zorro Lang
2024-04-30 0:25 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430102502.3167c16a@echidna \
--to=ddiss@suse.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox