* [PATCH] generic/747: Redirect stderr of _scratch_mkfs_sized
@ 2024-06-06 5:58 Ma Xinjian
2024-06-06 14:55 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Ma Xinjian @ 2024-06-06 5:58 UTC (permalink / raw)
To: fstests; +Cc: Ma Xinjian
The mkfs tool may output some information into stderr, which will cause the
output check failed.
In _scratch_mkfs_sized, the return value of mkfs tool is checked. So the
error message can be redirect to stdout, just like what other cases do.
Signed-off-by: Ma Xinjian <maxj.fnst@fujitsu.com>
---
tests/generic/747 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/747 b/tests/generic/747
index 50b7ae11..a0da1be5 100755
--- a/tests/generic/747
+++ b/tests/generic/747
@@ -99,7 +99,7 @@ seed=$RANDOM
RANDOM=$seed
echo "Running test with seed=$seed" >>$seqres.full
-_scratch_mkfs_sized $((8 * 1024 * 1024 * 1024)) >>$seqres.full
+_scratch_mkfs_sized $((8 * 1024 * 1024 * 1024)) >>$seqres.full 2>&1
_scratch_mount
echo "Starting fillup using direct IO"
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] generic/747: Redirect stderr of _scratch_mkfs_sized
2024-06-06 5:58 [PATCH] generic/747: Redirect stderr of _scratch_mkfs_sized Ma Xinjian
@ 2024-06-06 14:55 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2024-06-06 14:55 UTC (permalink / raw)
To: Ma Xinjian; +Cc: fstests
On Thu, Jun 06, 2024 at 01:58:00PM +0800, Ma Xinjian wrote:
> The mkfs tool may output some information into stderr, which will cause the
> output check failed.
>
> In _scratch_mkfs_sized, the return value of mkfs tool is checked. So the
> error message can be redirect to stdout, just like what other cases do.
Read list please
https://lore.kernel.org/fstests/171744525128.1531941.8755552045266618674.stgit@frogsfrogsfrogs/
--D
> Signed-off-by: Ma Xinjian <maxj.fnst@fujitsu.com>
> ---
> tests/generic/747 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/747 b/tests/generic/747
> index 50b7ae11..a0da1be5 100755
> --- a/tests/generic/747
> +++ b/tests/generic/747
> @@ -99,7 +99,7 @@ seed=$RANDOM
> RANDOM=$seed
> echo "Running test with seed=$seed" >>$seqres.full
>
> -_scratch_mkfs_sized $((8 * 1024 * 1024 * 1024)) >>$seqres.full
> +_scratch_mkfs_sized $((8 * 1024 * 1024 * 1024)) >>$seqres.full 2>&1
> _scratch_mount
>
> echo "Starting fillup using direct IO"
> --
> 2.39.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-06 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-06 5:58 [PATCH] generic/747: Redirect stderr of _scratch_mkfs_sized Ma Xinjian
2024-06-06 14:55 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox