FS/XFS testing framework
 help / color / mirror / Atom feed
From: Daniel Gomez <da.gomez@samsung.com>
To: "fstests@vger.kernel.org" <fstests@vger.kernel.org>
Cc: Pankaj Raghav <p.raghav@samsung.com>,
	"mcgrof@kernel.org" <mcgrof@kernel.org>,
	"hughd@google.com" <hughd@google.com>,
	Daniel Gomez <da.gomez@samsung.com>
Subject: [PATCH 0/5] tmpfs fixes
Date: Fri, 14 Jun 2024 06:17:24 +0000	[thread overview]
Message-ID: <20240614061722.1080-1-da.gomez@samsung.com> (raw)
In-Reply-To: CGME20240614061726eucas1p13b3cf24fce9d28ce29ee029224bf4378@eucas1p1.samsung.com

This series addresses some minor issues found in tmpfs FSQA suit test case.

The last patch adds information about mkfs and mount options for TEST and
SCRATCH devices. This is important to clarify especially if RECREATE_TEST_DEV
is disabled (which is the default case). The new output will look like the
following:

SECTION       -- tmpfs_noswap_huge_always
RECREATING    -- tmpfs on /media/test
FSTYP         -- tmpfs
PLATFORM      -- Linux/aarch64 localhost 6.10.0-rc3-dgc #6 SMP Thu Jun 13 22:48:46 CEST 2024
TEST device:
MKFS_OPTIONS  -- /media/test
MOUNT_OPTIONS -- -o size=1G /media/test /media/test
SCRATCH device:
MKFS_OPTIONS  -- /media/scratch
MOUNT_OPTIONS -- -o size=1G -o noswap,huge=always /media/scratch /media/scratch

Regarding $TMPFS_MOUNT_OPTIONS, when it is defined in the [default] section of
a configuration file, the mount options specified there will be prefixed to the
test section options. Is this the correct and expected behaviour?

Example:

```localhost.config
[default]
FSTYP=tmpfs
TEST_DIR=/media/test
SCRATCH_MNT=/media/scratch
SCRATCH_DEV=/media/scratch
RESULT_BASE=$PWD/results/$HOST/$(uname -r)
TEST_DEV=/media/test
CANON_DEVS=yes
TMPFS_MOUNT_OPTIONS="-o size=3G"

[tmpfs_noswap_huge_always]
TMPFS_MOUNT_OPTIONS="-o noswap,huge=always"
```

Note: The above config would result in '-o size=1G -o size=3G -o
noswap,huge=always' at mount time for tmpfs_noswap_huge_always section. The '-o
size=1G' is a hardcoded prefix mount option.

Daniel

Daniel Gomez (4):
  common/config: fix RECREATE_TEST_DEV initialization
  common/rc: add recreation support for tmpfs
  common/rc: fix scratch mount options for tmpfs
  common/rc: print scratch and test mount options

Hugh Dickins (1):
  generic/449: not run on tmpfs earlier

 check             |  4 ++++
 common/config     |  2 +-
 common/rc         | 25 ++++++++++++++++++++++---
 tests/generic/449 |  6 ++++++
 4 files changed, 33 insertions(+), 4 deletions(-)

-- 
2.43.0

       reply	other threads:[~2024-06-14  6:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240614061726eucas1p13b3cf24fce9d28ce29ee029224bf4378@eucas1p1.samsung.com>
2024-06-14  6:17 ` Daniel Gomez [this message]
2024-06-14  6:17   ` [PATCH 1/5] generic/449: not run on tmpfs earlier Daniel Gomez
2024-06-14 15:43     ` Darrick J. Wong
2024-06-14  6:17   ` [PATCH 2/5] common/config: fix RECREATE_TEST_DEV initialization Daniel Gomez
2024-06-14 15:44     ` Darrick J. Wong
2024-06-17  6:57     ` Zorro Lang
2024-06-14  6:17   ` [PATCH 4/5] common/rc: fix scratch mount options for tmpfs Daniel Gomez
2024-06-14 15:47     ` Darrick J. Wong
2024-06-24 13:50       ` Daniel Gomez
2024-06-24 16:47         ` Darrick J. Wong
2024-06-24 20:47           ` Daniel Gomez
2024-06-14  6:17   ` [PATCH 3/5] common/rc: add recreation support " Daniel Gomez
2024-06-14 15:48     ` Darrick J. Wong
2024-06-17  7:06     ` Zorro Lang
2024-06-24 13:33       ` Daniel Gomez
2024-06-28  3:13         ` Zorro Lang
2024-06-28 22:29           ` Daniel Gomez
2024-06-14  6:17   ` [PATCH 5/5] common/rc: print scratch and test mount options Daniel Gomez
2024-06-14 15:55     ` Darrick J. Wong
2024-06-24 14:02       ` Daniel Gomez
2024-06-24 16:24         ` Darrick J. Wong
2024-06-24 20:57           ` Daniel Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240614061722.1080-1-da.gomez@samsung.com \
    --to=da.gomez@samsung.com \
    --cc=fstests@vger.kernel.org \
    --cc=hughd@google.com \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox