From: Daniel Gomez <da.gomez@samsung.com>
To: "fstests@vger.kernel.org" <fstests@vger.kernel.org>
Cc: Pankaj Raghav <p.raghav@samsung.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"hughd@google.com" <hughd@google.com>,
Daniel Gomez <da.gomez@samsung.com>
Subject: [PATCH 5/5] common/rc: print scratch and test mount options
Date: Fri, 14 Jun 2024 06:17:26 +0000 [thread overview]
Message-ID: <20240614061722.1080-6-da.gomez@samsung.com> (raw)
In-Reply-To: <20240614061722.1080-1-da.gomez@samsung.com>
Mount options for a SCRATCH device might not be the same in the TEST
device if RECREATE_TEST_DEV is not enabled. So, print mount options for
each device to clarify this.
Add mount and mkfs info for TEST devices so we get the same information
being printed for both devices.
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
check | 4 ++++
common/rc | 20 ++++++++++++++++++--
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/check b/check
index 723a52e30..e02d28b39 100755
--- a/check
+++ b/check
@@ -807,7 +807,11 @@ function run_section()
# print out our test configuration
echo "FSTYP -- `_full_fstyp_details`"
echo "PLATFORM -- `_full_platform_details`"
+ echo "TEST device:"
+ echo "MKFS_OPTIONS -- `_test_mkfs_options`"
+ echo "MOUNT_OPTIONS -- `_test_mount_options`"
if [ ! -z "$SCRATCH_DEV" ]; then
+ echo "SCRATCH device:"
echo "MKFS_OPTIONS -- `_scratch_mkfs_options`"
echo "MOUNT_OPTIONS -- `_scratch_mount_options`"
fi
diff --git a/common/rc b/common/rc
index a42792c37..b351a82eb 100644
--- a/common/rc
+++ b/common/rc
@@ -235,6 +235,17 @@ _scratch_mount_options()
$SCRATCH_DEV $SCRATCH_MNT
}
+_test_mount_options()
+{
+ _test_options mount
+
+ if $RECREATE_TEST_DEV || [ "$OLD_FSTYP" != "$FSTYP" ]; then
+ echo $TEST_OPTIONS $TEST_FS_MOUNT_OPTS $SELINUX_MOUNT_OPTIONS $TMPFS_MOUNT_OPTIONS $* $TEST_DEV $TEST_DIR
+ else
+ echo $TEST_OPTIONS $TEST_FS_MOUNT_OPTS $SELINUX_MOUNT_OPTIONS $* $TEST_DEV $TEST_DIR
+ fi
+}
+
_supports_filetype()
{
local dir=$1
@@ -456,8 +467,7 @@ _test_mount()
return $?
fi
- _test_options mount
- _mount -t $FSTYP$FUSE_SUBTYP $TEST_OPTIONS $TEST_FS_MOUNT_OPTS $SELINUX_MOUNT_OPTIONS $TMPFS_MOUNT_OPTIONS $* $TEST_DEV $TEST_DIR
+ _mount -t $FSTYP$FUSE_SUBTYP `_test_mount_options $*`
mount_ret=$?
[ $mount_ret -ne 0 ] && return $mount_ret
_idmapped_mount $TEST_DEV $TEST_DIR
@@ -571,6 +581,12 @@ _metadump_dev() {
esac
}
+_test_mkfs_options()
+{
+ _test_options mkfs
+ echo $TEST_OPTIONS $MKFS_OPTIONS $* $TEST_DEV
+}
+
_test_mkfs()
{
case $FSTYP in
--
2.43.0
next prev parent reply other threads:[~2024-06-14 6:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240614061726eucas1p13b3cf24fce9d28ce29ee029224bf4378@eucas1p1.samsung.com>
2024-06-14 6:17 ` [PATCH 0/5] tmpfs fixes Daniel Gomez
2024-06-14 6:17 ` [PATCH 2/5] common/config: fix RECREATE_TEST_DEV initialization Daniel Gomez
2024-06-14 15:44 ` Darrick J. Wong
2024-06-17 6:57 ` Zorro Lang
2024-06-14 6:17 ` [PATCH 1/5] generic/449: not run on tmpfs earlier Daniel Gomez
2024-06-14 15:43 ` Darrick J. Wong
2024-06-14 6:17 ` [PATCH 4/5] common/rc: fix scratch mount options for tmpfs Daniel Gomez
2024-06-14 15:47 ` Darrick J. Wong
2024-06-24 13:50 ` Daniel Gomez
2024-06-24 16:47 ` Darrick J. Wong
2024-06-24 20:47 ` Daniel Gomez
2024-06-14 6:17 ` [PATCH 3/5] common/rc: add recreation support " Daniel Gomez
2024-06-14 15:48 ` Darrick J. Wong
2024-06-17 7:06 ` Zorro Lang
2024-06-24 13:33 ` Daniel Gomez
2024-06-28 3:13 ` Zorro Lang
2024-06-28 22:29 ` Daniel Gomez
2024-06-14 6:17 ` Daniel Gomez [this message]
2024-06-14 15:55 ` [PATCH 5/5] common/rc: print scratch and test mount options Darrick J. Wong
2024-06-24 14:02 ` Daniel Gomez
2024-06-24 16:24 ` Darrick J. Wong
2024-06-24 20:57 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614061722.1080-6-da.gomez@samsung.com \
--to=da.gomez@samsung.com \
--cc=fstests@vger.kernel.org \
--cc=hughd@google.com \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox