From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
linux-ext4@vger.kernel.org
Subject: [PATCH 4/8] generic/740: skip jffs2 as foreign fs earlier
Date: Sun, 23 Jun 2024 14:10:33 +0200 [thread overview]
Message-ID: <20240623121103.974270-5-hch@lst.de> (raw)
In-Reply-To: <20240623121103.974270-1-hch@lst.de>
Commit a633d252e3c4 ("shared/032: add options for jffs2") added a
check to skip checking the overwrite of jffs2, but only after
adding specific mkfs options for it and zeroing part of the device.
Switch to skipping it earlier in a more obvious place.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/generic/740 | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/generic/740 b/tests/generic/740
index 6a97ac69a..bac927227 100755
--- a/tests/generic/740
+++ b/tests/generic/740
@@ -46,8 +46,8 @@ do
preargs="-p lock_nolock -j 1"
;;
jffs2)
- # jffs2 mkfs requires '-r $directory' and '-o $image'
- preargs="-r /proc/fs -o"
+ # mkfs.jffs2 doesn't work like a normal mkfs and just fails
+ continue;
;;
jfs)
preop="echo Y |"
@@ -79,8 +79,6 @@ do
if [ $? -eq 0 ] ; then
# next, ensure we don't overwrite it
- # jffs2 mkfs doesn't check overwrite case
- [ $fs = jffs2 ] && continue
echo "=== Attempting $FSTYP overwrite of $fs..." >>$seqres.full
${MKFS_PROG} -t $FSTYP $SCRATCH_DEV >>$seqres.full 2>&1
--
2.43.0
next prev parent reply other threads:[~2024-06-23 12:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 12:10 mostly remove _supported_fs Christoph Hellwig
2024-06-23 12:10 ` [PATCH 1/8] remove support for ext4dev Christoph Hellwig
2024-06-23 12:10 ` [PATCH 2/8] generic/740: clean up handling of mkfs options Christoph Hellwig
2024-06-23 12:10 ` [PATCH 3/8] generic/740: pass the --quick option to mkfs.ntfs Christoph Hellwig
2024-06-23 12:10 ` Christoph Hellwig [this message]
2024-06-23 12:10 ` [PATCH 5/8] generic/740: enable by default Christoph Hellwig
2024-06-24 16:16 ` Darrick J. Wong
2024-06-25 3:50 ` Theodore Ts'o
2024-06-25 6:00 ` Christoph Hellwig
2024-06-25 20:05 ` Theodore Ts'o
2024-06-26 4:01 ` Christoph Hellwig
2024-06-23 12:10 ` [PATCH 6/8] generic/745: rework support fs checking Christoph Hellwig
2024-06-23 12:10 ` [PATCH 7/8] generic/746: clean up fs support Christoph Hellwig
2024-06-23 12:10 ` [PATCH 8/8] remove spurious _supported_fs calls Christoph Hellwig
2024-06-24 2:17 ` mostly remove _supported_fs David Disseldorp
2024-06-24 16:17 ` Darrick J. Wong
2024-07-10 6:16 ` Christoph Hellwig
2024-07-11 13:16 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240623121103.974270-5-hch@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox