FS/XFS testing framework
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
	linux-ext4@vger.kernel.org
Subject: [PATCH 5/8] generic/740: enable by default
Date: Sun, 23 Jun 2024 14:10:34 +0200	[thread overview]
Message-ID: <20240623121103.974270-6-hch@lst.de> (raw)
In-Reply-To: <20240623121103.974270-1-hch@lst.de>

Instead of limiting this test to a few file systems, opt out the
file systems supported in common/rc that don't support overwrite
checking at all, and those like extN that support it, but only when
run interactively.

Also remove support for really old mkfs.btrfs versions that lack
the overwrite check.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/generic/740 | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/tests/generic/740 b/tests/generic/740
index bac927227..903e891db 100755
--- a/tests/generic/740
+++ b/tests/generic/740
@@ -12,19 +12,16 @@ _begin_fstest mkfs auto quick
 # Import common functions.
 . ./common/filter
 
-# real QA test starts here
-_supported_fs xfs btrfs
+# a bunch of file systems don't support foreign fs detection
+# ext* do support it, but disable the feature when called non-interactively
+_supported_fs ^ext2 ^ext3 ^ext4 ^jfs ^ocfs2 ^udf
 
-_require_scratch_nocheck
-_require_no_large_scratch_dev
+_require_block_device "${SCRATCH_DEV}"
 # not all the FS support zoned block device
 _require_non_zoned_device "${SCRATCH_DEV}"
 
-# mkfs.btrfs did not have overwrite detection at first
-if [ "$FSTYP" == "btrfs" ]; then
-	grep -q 'force overwrite' `echo $MKFS_BTRFS_PROG | awk '{print $1}'` || \
-		_notrun "Installed mkfs.btrfs does not support -f option"
-fi
+_require_scratch_nocheck
+_require_no_large_scratch_dev
 
 echo "Silence is golden."
 for fs in `echo ${MKFS_PROG}.* | sed -e "s:${MKFS_PROG}.::g"`
-- 
2.43.0


  parent reply	other threads:[~2024-06-23 12:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-23 12:10 mostly remove _supported_fs Christoph Hellwig
2024-06-23 12:10 ` [PATCH 1/8] remove support for ext4dev Christoph Hellwig
2024-06-23 12:10 ` [PATCH 2/8] generic/740: clean up handling of mkfs options Christoph Hellwig
2024-06-23 12:10 ` [PATCH 3/8] generic/740: pass the --quick option to mkfs.ntfs Christoph Hellwig
2024-06-23 12:10 ` [PATCH 4/8] generic/740: skip jffs2 as foreign fs earlier Christoph Hellwig
2024-06-23 12:10 ` Christoph Hellwig [this message]
2024-06-24 16:16   ` [PATCH 5/8] generic/740: enable by default Darrick J. Wong
2024-06-25  3:50     ` Theodore Ts'o
2024-06-25  6:00       ` Christoph Hellwig
2024-06-25 20:05         ` Theodore Ts'o
2024-06-26  4:01           ` Christoph Hellwig
2024-06-23 12:10 ` [PATCH 6/8] generic/745: rework support fs checking Christoph Hellwig
2024-06-23 12:10 ` [PATCH 7/8] generic/746: clean up fs support Christoph Hellwig
2024-06-23 12:10 ` [PATCH 8/8] remove spurious _supported_fs calls Christoph Hellwig
2024-06-24  2:17 ` mostly remove _supported_fs David Disseldorp
2024-06-24 16:17 ` Darrick J. Wong
2024-07-10  6:16 ` Christoph Hellwig
2024-07-11 13:16   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240623121103.974270-6-hch@lst.de \
    --to=hch@lst.de \
    --cc=fstests@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox