FS/XFS testing framework
 help / color / mirror / Atom feed
From: Daniel Gomez via B4 Relay <devnull+da.gomez.samsung.com@kernel.org>
To: fstests@vger.kernel.org
Cc: "Darrick J. Wong" <djwong@kernel.org>,
	Zorro Lang <zlang@redhat.com>,
	 mcgrof@kernel.org, gost.dev@samsung.com,
	 Samsung Samsung <"Daniel Gomez d+samsung"@kruces.com>,
	 Daniel Gomez <da.gomez@samsung.com>
Subject: [PATCH v2 1/5] common/config: fix RECREATE_TEST_DEV initialization
Date: Sun, 30 Jun 2024 23:52:40 +0200	[thread overview]
Message-ID: <20240630-common-fixes-v2-1-16d26fb1dee0@samsung.com> (raw)
In-Reply-To: <20240630-common-fixes-v2-0-16d26fb1dee0@samsung.com>

From: Daniel Gomez <da.gomez@samsung.com>

Do not allow the overwriting of the RECREATE_TEST_DEV variable. When
this variable is enabled, common/rc -> common/config will reset it
to false after the test device recreation process. This allows for
differentiation in mount options for SCRATCH and TEST.

Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Zorro Lang <zlang@redhat.com>
---
 common/config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/config b/common/config
index a1cd14de6..43b32b93d 100644
--- a/common/config
+++ b/common/config
@@ -94,7 +94,7 @@ export PWD=`pwd`
 export MALLOCLIB=${MALLOCLIB:=/usr/lib/libefence.a}
 export LOCAL_CONFIGURE_OPTIONS=${LOCAL_CONFIGURE_OPTIONS:=--enable-readline=yes}
 
-export RECREATE_TEST_DEV=false
+export RECREATE_TEST_DEV=${RECREATE_TEST_DEV:=false}
 
 # Handle mkfs.$fstyp which does (or does not) require -f to overwrite
 set_mkfs_prog_path_with_opts()

-- 
2.43.0



  reply	other threads:[~2024-07-01 14:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-30 21:52 [PATCH v2 0/5] common fixes Daniel Gomez via B4 Relay
2024-06-30 21:52 ` Daniel Gomez via B4 Relay [this message]
2024-06-30 21:52 ` [PATCH v2 2/5] common/rc: add recreation support for tmpfs Daniel Gomez via B4 Relay
2024-07-01 22:36   ` Darrick J. Wong
2024-07-05 21:46     ` Daniel Gomez (Samsung)
2024-07-08 17:34       ` Darrick J. Wong
2024-06-30 21:52 ` [PATCH v2 3/5] common/config: enable section parsing when recreation Daniel Gomez via B4 Relay
2024-06-30 21:52 ` [PATCH v2 4/5] common/rc: read config section mount options for scratch devs Daniel Gomez via B4 Relay
2024-07-12  9:26   ` Zirong Lang
2024-07-12  9:49   ` Zorro Lang
2024-07-15  8:17     ` Daniel Gomez
2024-08-05 12:04     ` Daniel Gomez
2024-08-06 13:11       ` Zorro Lang
2024-06-30 21:52 ` [PATCH v2 5/5] common/rc: print test mount options Daniel Gomez via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240630-common-fixes-v2-1-16d26fb1dee0@samsung.com \
    --to=devnull+da.gomez.samsung.com@kernel.org \
    --cc="Daniel Gomez d+samsung"@kruces.com \
    --cc=da.gomez@samsung.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=gost.dev@samsung.com \
    --cc=mcgrof@kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox