From: Daniel Gomez via B4 Relay <devnull+da.gomez.samsung.com@kernel.org>
To: fstests@vger.kernel.org
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Zorro Lang <zlang@redhat.com>,
mcgrof@kernel.org, gost.dev@samsung.com,
Samsung Samsung <"Daniel Gomez d+samsung"@kruces.com>,
Daniel Gomez <da.gomez@samsung.com>
Subject: [PATCH v2 5/5] common/rc: print test mount options
Date: Sun, 30 Jun 2024 23:52:44 +0200 [thread overview]
Message-ID: <20240630-common-fixes-v2-5-16d26fb1dee0@samsung.com> (raw)
In-Reply-To: <20240630-common-fixes-v2-0-16d26fb1dee0@samsung.com>
From: Daniel Gomez <da.gomez@samsung.com>
Mount options for a SCRATCH device might not be the same for a TEST
device if RECREATE_TEST_DEV is not enabled. Add mount options for TEST
devices when printing fstest header to clarify this.
Add mount and mkfs info for TEST devices so we get the same information
being printed for both devices.
Export new TEST_{MKFS/MOUNT}_OPTIONS and include them in the report.
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
check | 2 ++
common/rc | 19 ++++++++++++++++++-
common/report | 1 +
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/check b/check
index 9222cd7e4..ca30771c5 100755
--- a/check
+++ b/check
@@ -819,6 +819,8 @@ function run_section()
# print out our test configuration
echo "FSTYP -- `_full_fstyp_details`"
echo "PLATFORM -- `_full_platform_details`"
+ echo "TEST_MKFS_OPTIONS -- `_test_mkfs_options`"
+ echo "TEST_MOUNT_OPTIONS -- `_test_mount_options`"
if [ ! -z "$SCRATCH_DEV" ]; then
echo "MKFS_OPTIONS -- `_scratch_mkfs_options`"
echo "MOUNT_OPTIONS -- `_scratch_mount_options`"
diff --git a/common/rc b/common/rc
index 627dbaaaa..bbbd274a7 100644
--- a/common/rc
+++ b/common/rc
@@ -235,6 +235,15 @@ _scratch_mount_options()
$SCRATCH_DEV $SCRATCH_MNT $*
}
+_test_mount_options()
+{
+ _test_options mount
+
+ export TEST_MOUNT_OPTIONS="$TEST_OPTIONS $TEST_FS_MOUNT_OPTS \
+ $SELINUX_MOUNT_OPTIONS $* $TEST_DEV $TEST_DIR"
+ echo $TEST_MOUNT_OPTIONS
+}
+
_supports_filetype()
{
local dir=$1
@@ -457,7 +466,7 @@ _test_mount()
fi
_test_options mount
- _mount -t $FSTYP$FUSE_SUBTYP $TEST_OPTIONS $TEST_FS_MOUNT_OPTS $SELINUX_MOUNT_OPTIONS $* $TEST_DEV $TEST_DIR
+ _mount -t $FSTYP$FUSE_SUBTYP `_test_mount_options $*`
mount_ret=$?
[ $mount_ret -ne 0 ] && return $mount_ret
_idmapped_mount $TEST_DEV $TEST_DIR
@@ -571,6 +580,14 @@ _metadump_dev() {
esac
}
+_test_mkfs_options()
+{
+ _test_options mkfs
+
+ export TEST_MKFS_OPTIONS="$TEST_OPTIONS $MKFS_OPTIONS $* $TEST_DEV"
+ echo $TEST_MKFS_OPTIONS
+}
+
_test_mkfs()
{
case $FSTYP in
diff --git a/common/report b/common/report
index 0e91e481f..44de33e61 100644
--- a/common/report
+++ b/common/report
@@ -5,6 +5,7 @@
# List of xfstests's enviroment variables to include reports
## TODO automate list population inside common/conf
REPORT_ENV_LIST=("SECTION" "FSTYP" "PLATFORM" "MKFS_OPTIONS" "MOUNT_OPTIONS" \
+ "TEST_MKFS_OPTIONS" "TEST_MOUNT_OPTIONS" \
"HOST_OPTIONS" "CHECK_OPTIONS" "XFS_MKFS_OPTIONS" \
"TIME_FACTOR" "LOAD_FACTOR" "TEST_DIR" "TEST_DEV" \
"SCRATCH_DEV" "SCRATCH_MNT" "OVL_UPPER" "OVL_LOWER" "OVL_WORK")
--
2.43.0
prev parent reply other threads:[~2024-07-01 14:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 21:52 [PATCH v2 0/5] common fixes Daniel Gomez via B4 Relay
2024-06-30 21:52 ` [PATCH v2 1/5] common/config: fix RECREATE_TEST_DEV initialization Daniel Gomez via B4 Relay
2024-06-30 21:52 ` [PATCH v2 2/5] common/rc: add recreation support for tmpfs Daniel Gomez via B4 Relay
2024-07-01 22:36 ` Darrick J. Wong
2024-07-05 21:46 ` Daniel Gomez (Samsung)
2024-07-08 17:34 ` Darrick J. Wong
2024-06-30 21:52 ` [PATCH v2 3/5] common/config: enable section parsing when recreation Daniel Gomez via B4 Relay
2024-06-30 21:52 ` [PATCH v2 4/5] common/rc: read config section mount options for scratch devs Daniel Gomez via B4 Relay
2024-07-12 9:26 ` Zirong Lang
2024-07-12 9:49 ` Zorro Lang
2024-07-15 8:17 ` Daniel Gomez
2024-08-05 12:04 ` Daniel Gomez
2024-08-06 13:11 ` Zorro Lang
2024-06-30 21:52 ` Daniel Gomez via B4 Relay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240630-common-fixes-v2-5-16d26fb1dee0@samsung.com \
--to=devnull+da.gomez.samsung.com@kernel.org \
--cc="Daniel Gomez d+samsung"@kruces.com \
--cc=da.gomez@samsung.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=gost.dev@samsung.com \
--cc=mcgrof@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox