* [PATCH] fstests: add missing kernel git commit IDs to some tests
@ 2024-09-12 11:26 fdmanana
2024-09-16 21:21 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: fdmanana @ 2024-09-12 11:26 UTC (permalink / raw)
To: fstests; +Cc: linux-btrfs, Filipe Manana
From: Filipe Manana <fdmanana@suse.com>
Three tests (btrfs/321, generic/364 and xfs/608) refer to kernel patches
that are now in Linus' git kernel tree, so update the tests to include
the commit IDs.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
tests/btrfs/321 | 2 +-
tests/generic/364 | 2 +-
tests/xfs/608 | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/btrfs/321 b/tests/btrfs/321
index e30199da..93935530 100755
--- a/tests/btrfs/321
+++ b/tests/btrfs/321
@@ -22,7 +22,7 @@ _require_btrfs_raid_type raid0
_require_btrfs_support_sectorsize 4096
_require_btrfs_command inspect-internal dump-tree
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit 10d9d8c3512f \
"btrfs: fix a use-after-free bug when hitting errors inside btrfs_submit_chunk()"
# The bug itself has a race window, run this many times to ensure triggering.
diff --git a/tests/generic/364 b/tests/generic/364
index 34029597..968b4754 100755
--- a/tests/generic/364
+++ b/tests/generic/364
@@ -18,7 +18,7 @@ _require_command "$TIMEOUT_PROG" timeout
# Triggers very frequently with kernel config CONFIG_BTRFS_ASSERT=y.
[ $FSTYP == "btrfs" ] && \
- _fixed_by_kernel_commit xxxxxxxxxxxx \
+ _fixed_by_kernel_commit cd9253c23aed \
"btrfs: fix race between direct IO write and fsync when using same fd"
# On error the test program writes messages to stderr, causing a golden output
diff --git a/tests/xfs/608 b/tests/xfs/608
index a74c7bf3..7ac40137 100755
--- a/tests/xfs/608
+++ b/tests/xfs/608
@@ -9,7 +9,7 @@
. ./common/preamble
_begin_fstest auto
-_fixed_by_kernel_commit XXXXXXXXXXXX \
+_fixed_by_kernel_commit e21fea4ac3cf \
"xfs: fix di_onlink checking for V1/V2 inodes",
_require_scratch_nocheck # we'll do our own checking
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fstests: add missing kernel git commit IDs to some tests
2024-09-12 11:26 [PATCH] fstests: add missing kernel git commit IDs to some tests fdmanana
@ 2024-09-16 21:21 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2024-09-16 21:21 UTC (permalink / raw)
To: fdmanana; +Cc: fstests, linux-btrfs, Filipe Manana
On Thu, Sep 12, 2024 at 12:26:38PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> Three tests (btrfs/321, generic/364 and xfs/608) refer to kernel patches
> that are now in Linus' git kernel tree, so update the tests to include
> the commit IDs.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---
> tests/btrfs/321 | 2 +-
> tests/generic/364 | 2 +-
> tests/xfs/608 | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/btrfs/321 b/tests/btrfs/321
> index e30199da..93935530 100755
> --- a/tests/btrfs/321
> +++ b/tests/btrfs/321
> @@ -22,7 +22,7 @@ _require_btrfs_raid_type raid0
> _require_btrfs_support_sectorsize 4096
> _require_btrfs_command inspect-internal dump-tree
>
> -_fixed_by_kernel_commit xxxxxxxxxxxx \
> +_fixed_by_kernel_commit 10d9d8c3512f \
> "btrfs: fix a use-after-free bug when hitting errors inside btrfs_submit_chunk()"
>
> # The bug itself has a race window, run this many times to ensure triggering.
> diff --git a/tests/generic/364 b/tests/generic/364
> index 34029597..968b4754 100755
> --- a/tests/generic/364
> +++ b/tests/generic/364
> @@ -18,7 +18,7 @@ _require_command "$TIMEOUT_PROG" timeout
>
> # Triggers very frequently with kernel config CONFIG_BTRFS_ASSERT=y.
> [ $FSTYP == "btrfs" ] && \
> - _fixed_by_kernel_commit xxxxxxxxxxxx \
> + _fixed_by_kernel_commit cd9253c23aed \
> "btrfs: fix race between direct IO write and fsync when using same fd"
>
> # On error the test program writes messages to stderr, causing a golden output
> diff --git a/tests/xfs/608 b/tests/xfs/608
> index a74c7bf3..7ac40137 100755
> --- a/tests/xfs/608
> +++ b/tests/xfs/608
> @@ -9,7 +9,7 @@
> . ./common/preamble
> _begin_fstest auto
>
> -_fixed_by_kernel_commit XXXXXXXXXXXX \
> +_fixed_by_kernel_commit e21fea4ac3cf \
> "xfs: fix di_onlink checking for V1/V2 inodes",
Yep, thank you...
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
>
> _require_scratch_nocheck # we'll do our own checking
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-16 21:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 11:26 [PATCH] fstests: add missing kernel git commit IDs to some tests fdmanana
2024-09-16 21:21 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox