[PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line

[PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line

[Chao Yu]

The bug related to this regression testcase has been fixed by commit
d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call
f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit
line.

Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
---
 tests/f2fs/005 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/f2fs/005 b/tests/f2fs/005
index a817d51a..33d4fdb9 100755
--- a/tests/f2fs/005
+++ b/tests/f2fs/005
@@ -11,7 +11,7 @@
 . ./common/preamble
 _begin_fstest auto quick
 
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit d5c367ef8287 \
 	"f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."
 
 _require_scratch
-- 
2.40.1

[PATCH 2/3] f2fs/006: update commit id in _fixed_by_kernel_commit line

[Chao Yu]

The bug related to this regression testcase has been fixed by commit
1acd73edbbfe ("f2fs: fix to account dirty data in __get_secs_required()"),
let's update commit id in _fixed_by_kernel_commit line.

Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
---
 tests/f2fs/006 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/f2fs/006 b/tests/f2fs/006
index a9c823c1..c1f8d4ff 100755
--- a/tests/f2fs/006
+++ b/tests/f2fs/006
@@ -16,7 +16,7 @@
 . ./common/preamble
 _begin_fstest auto quick
 
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit 1acd73edbbfe \
 	"f2fs: fix to account dirty data in __get_secs_required()"
 
 _require_scratch
-- 
2.40.1

[PATCH 3/3] f2fs/007: update commit id in _fixed_by_kernel_commit line

[Chao Yu]

The bug related to this regression testcase has been fixed by commit
26413ce18e85 ("f2fs: compress: fix inconsistent update of i_blocks in
release_compress_blocks and reserve_compress_blocks"), let's update
commit id in _fixed_by_kernel_commit line.

Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
---
 tests/f2fs/007 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/f2fs/007 b/tests/f2fs/007
index 6451d4b4..37388433 100755
--- a/tests/f2fs/007
+++ b/tests/f2fs/007
@@ -11,7 +11,7 @@
 . ./common/preamble
 _begin_fstest auto quick rw compress
 
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit 26413ce18e85 \
         "f2fs: compress: fix inconsistent update of i_blocks in release_compress_blocks and reserve_compress_blocks"
 
 _require_scratch
-- 
2.40.1

Re: [PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line

[Zorro Lang]

On Mon, Dec 02, 2024 at 07:41:47PM +0800, Chao Yu wrote:
> The bug related to this regression testcase has been fixed by commit
> d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call
> f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit
> line.
> 
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
>  tests/f2fs/005 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/f2fs/005 b/tests/f2fs/005
> index a817d51a..33d4fdb9 100755
> --- a/tests/f2fs/005
> +++ b/tests/f2fs/005
> @@ -11,7 +11,7 @@
>  . ./common/preamble
>  _begin_fstest auto quick
>  
> -_fixed_by_kernel_commit xxxxxxxxxxxx \
> +_fixed_by_kernel_commit d5c367ef8287 \
>  	"f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."

I think we don't need to use 3 patches. As you just add missed commit id number,
just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit".
Or if you hope I can do that when I merge it, feel free to tell me :)

Others look good to me, with above change:

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  
>  _require_scratch
> -- 
> 2.40.1
> 

Re: [PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line

[Chao Yu]

On 2024/12/3 3:28, Zorro Lang wrote:
> On Mon, Dec 02, 2024 at 07:41:47PM +0800, Chao Yu wrote:
>> The bug related to this regression testcase has been fixed by commit
>> d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call
>> f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit
>> line.
>>
>> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>>   tests/f2fs/005 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/f2fs/005 b/tests/f2fs/005
>> index a817d51a..33d4fdb9 100755
>> --- a/tests/f2fs/005
>> +++ b/tests/f2fs/005
>> @@ -11,7 +11,7 @@
>>   . ./common/preamble
>>   _begin_fstest auto quick
>>   
>> -_fixed_by_kernel_commit xxxxxxxxxxxx \
>> +_fixed_by_kernel_commit d5c367ef8287 \
>>   	"f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."
> 
> I think we don't need to use 3 patches. As you just add missed commit id number,
> just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit".
> Or if you hope I can do that when I merge it, feel free to tell me :)

Zorro,

I've sent a new patch, can you please help to review it? thank you.

Thanks,

> 
> Others look good to me, with above change:
> 
> Reviewed-by: Zorro Lang <zlang@redhat.com>
> 
>>   
>>   _require_scratch
>> -- 
>> 2.40.1
>>
>