From: Su Yue <glass.su@suse.com>
To: fstests@vger.kernel.org
Cc: ocfs2-devel@lists.linux.dev, Su Yue <glass.su@suse.com>
Subject: [PATCH] common/quota: filter out option projquota in _qmount_option for ocfs2
Date: Mon, 6 Jan 2025 22:01:24 +0800 [thread overview]
Message-ID: <20250106140124.91928-1-glass.su@suse.com> (raw)
ocfs2 doesn't support projquota but does support usrquota an grpquota.
For now, two tests generic/594 and generic/603 are for testing
usrquota,grpquota and projquota. The mount option 'projquota' causes
failure of ocfs2 mount.
To make things simple, just skip the tests for ocfs2.
However, we can't just put '_require_prjquota $SCRATCH_DEV' before
_qmount because f2fs and xfs need runtime after mount of SCRATCH_DEV.
For ocfs2, filter out option 'projquota' in _qmount_option() to make
_qmount successful. Then in _require_prjquota(), ocfs2 will fallthrough
as a no kernel projquota support fs type.
Signed-off-by: Su Yue <glass.su@suse.com>
---
common/quota | 3 +++
1 file changed, 3 insertions(+)
diff --git a/common/quota b/common/quota
index 8135b7c044bf..8688116c6547 100644
--- a/common/quota
+++ b/common/quota
@@ -325,6 +325,9 @@ _qmount_option()
OPTS=`echo $OPTS \
| sed -e 's/\bpquota/quota/g' \
-e 's/prjquota/quota/g'`
+ # ocfs2 doesn't support "-o projquota"
+ elif [[ "$FSTYP" == ocfs2 ]]; then
+ OPTS=`echo $OPTS | sed -e 's/prjquota//g'`
fi
# Ensure we have the given quota option - duplicates are fine
if [ -n "$OPTS" ]; then
--
2.47.1
next reply other threads:[~2025-01-06 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 14:01 Su Yue [this message]
2025-01-06 17:47 ` [PATCH] common/quota: filter out option projquota in _qmount_option for ocfs2 David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106140124.91928-1-glass.su@suse.com \
--to=glass.su@suse.com \
--cc=fstests@vger.kernel.org \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox