From: David Disseldorp <ddiss@suse.de>
To: Su Yue <glass.su@suse.com>
Cc: fstests@vger.kernel.org, ocfs2-devel@lists.linux.dev
Subject: Re: [PATCH] common/quota: filter out option projquota in _qmount_option for ocfs2
Date: Tue, 7 Jan 2025 04:47:02 +1100 [thread overview]
Message-ID: <20250107044702.7fb7edaa.ddiss@suse.de> (raw)
In-Reply-To: <20250106140124.91928-1-glass.su@suse.com>
On Mon, 6 Jan 2025 22:01:24 +0800, Su Yue wrote:
> ocfs2 doesn't support projquota but does support usrquota an grpquota.
> For now, two tests generic/594 and generic/603 are for testing
> usrquota,grpquota and projquota. The mount option 'projquota' causes
> failure of ocfs2 mount.
>
> To make things simple, just skip the tests for ocfs2.
> However, we can't just put '_require_prjquota $SCRATCH_DEV' before
> _qmount because f2fs and xfs need runtime after mount of SCRATCH_DEV.
All _require_prjquota callers provide a $SCRATCH_DEV parameter, so
changing the order and mkfsing / mounting to check support for f2fs and
xfs should be an option. Still, this approach looks reasonable too:
Reviewed-by: David Disseldorp <ddiss@suse.de>
prev parent reply other threads:[~2025-01-06 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 14:01 [PATCH] common/quota: filter out option projquota in _qmount_option for ocfs2 Su Yue
2025-01-06 17:47 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107044702.7fb7edaa.ddiss@suse.de \
--to=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
--cc=glass.su@suse.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox