From: "Darrick J. Wong" <djwong@kernel.org>
To: Su Yue <glass.su@suse.com>
Cc: fstests@vger.kernel.org, ocfs2-devel@lists.linux.dev
Subject: Re: [PATCH] generic/620: add '-J block64' mkfs option for ocfs2
Date: Mon, 6 Jan 2025 18:12:54 -0800 [thread overview]
Message-ID: <20250107021254.GP6160@frogsfrogsfrogs> (raw)
In-Reply-To: <20250106140104.91880-1-glass.su@suse.com>
On Mon, Jan 06, 2025 at 10:01:04PM +0800, Su Yue wrote:
> mkfs.ocfs2 is using 32bit journal as default.
> For 16T size device support, '-J block64' should be used.
>
> Signed-off-by: Su Yue <glass.su@suse.com>
> ---
> tests/generic/620 | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/generic/620 b/tests/generic/620
> index 3f1ce45a55fd..60e5a2cacdda 100755
> --- a/tests/generic/620
> +++ b/tests/generic/620
> @@ -41,6 +41,9 @@ sectors=$((2*1024*1024*1024*17))
> chunk_size=128
>
> _dmhugedisk_init $sectors $chunk_size
> +
> +[ "$FSTYP" = "ocfs2" ] && MKFS_OPTIONS="$MKFS_OPTIONS -J block64"
Won't mkfs.ocfs2 turn on block64 on a > 16T volume without prompting?
--D
> +
> _mkfs_dev $DMHUGEDISK_DEV
> _mount $DMHUGEDISK_DEV $SCRATCH_MNT || _fail "mount failed for $DMHUGEDISK_DEV $SCRATCH_MNT"
> testfile=$SCRATCH_MNT/testfile-$seq
> --
> 2.47.1
>
>
next prev parent reply other threads:[~2025-01-07 2:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 14:01 [PATCH] generic/620: add '-J block64' mkfs option for ocfs2 Su Yue
2025-01-06 16:30 ` Christoph Hellwig
2025-01-07 2:50 ` Glass Su
2025-01-06 16:39 ` David Disseldorp
2025-01-07 2:45 ` Glass Su
2025-01-07 2:12 ` Darrick J. Wong [this message]
2025-01-07 2:42 ` Glass Su
2025-01-07 11:38 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107021254.GP6160@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=glass.su@suse.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox