From: Glass Su <glass.su@suse.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: fstests@vger.kernel.org, ocfs2-devel@lists.linux.dev
Subject: Re: [PATCH] generic/620: add '-J block64' mkfs option for ocfs2
Date: Tue, 7 Jan 2025 10:50:03 +0800 [thread overview]
Message-ID: <AFFEA381-1C08-46B6-97B7-9F7DD954BE0F@suse.com> (raw)
In-Reply-To: <Z3wFFs371-WNVreY@infradead.org>
> On Jan 7, 2025, at 00:30, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Mon, Jan 06, 2025 at 10:01:04PM +0800, Su Yue wrote:
>> mkfs.ocfs2 is using 32bit journal as default.
>> For 16T size device support, '-J block64' should be used.
>
> Hard coding this into a specific test is weird. I would expect
> mkfs to pick the right one, but maybe the maintainers have a good
> reason for not doing that?
>
Sounds more reasonable. 64bit journal support of ocfs2 was added in
2008, 17 gears agao...
—
Su
> But if not you probably want to force it in your config file or
> we need a workaround in _try_mkfs_dev.
>
next prev parent reply other threads:[~2025-01-07 2:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 14:01 [PATCH] generic/620: add '-J block64' mkfs option for ocfs2 Su Yue
2025-01-06 16:30 ` Christoph Hellwig
2025-01-07 2:50 ` Glass Su [this message]
2025-01-06 16:39 ` David Disseldorp
2025-01-07 2:45 ` Glass Su
2025-01-07 2:12 ` Darrick J. Wong
2025-01-07 2:42 ` Glass Su
2025-01-07 11:38 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AFFEA381-1C08-46B6-97B7-9F7DD954BE0F@suse.com \
--to=glass.su@suse.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox