[PATCH] generic/370: don't exclude XFS

[PATCH] generic/370: don't exclude XFS

[Christoph Hellwig]

Skipping tests just because a file system is broken is always a bad idea
as it hides bugs.

(Fortunately despite hiding the bug this is now getting fixed in XFS as
 well).

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/generic/370 | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/tests/generic/370 b/tests/generic/370
index 8adffd2e9650..8101ef42724e 100755
--- a/tests/generic/370
+++ b/tests/generic/370
@@ -22,14 +22,6 @@ _cleanup()
 [ "$FSTYP" = "btrfs" ] && _fixed_by_kernel_commit 03018e5d8508 \
     "btrfs: fix swap file activation failure due to extents that used to be shared"
 
-# Skip XFS for now because this exposes an issue that is hard to fix.
-# See the following threads for details about it:
-#
-# https://lore.kernel.org/linux-xfs/CAL3q7H7cURmnkJfUUx44HM3q=xKmqHb80eRdisErD_x8rU4+0Q@mail.gmail.com/
-# https://lore.kernel.org/fstests/dca49a16a7aacdab831b8895bdecbbb52c0e609c.1733928765.git.fdmanana@suse.com/
-#
-_exclude_fs xfs
-
 _require_scratch_swapfile
 _require_scratch_reflink
 _require_cp_reflink
-- 
2.45.2

Re: [PATCH] generic/370: don't exclude XFS

[Zorro Lang]

On Mon, Feb 17, 2025 at 07:31:35AM +0100, Christoph Hellwig wrote:
> Skipping tests just because a file system is broken is always a bad idea
> as it hides bugs.

Skipping this test due to I'm not sure if xfs treats it as a bug or a boring
test failure which isn't suit for xfs. So I have to choose to skip it
temporarily with enough explanation, as btrfs was hurry to have this merge
and there was not objection from xfs either at that time.

> 
> (Fortunately despite hiding the bug this is now getting fixed in XFS as
>  well).

Great to hear that:)

Reviewed-by: Zorro Lang <zlang@redhat.com>

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/generic/370 | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tests/generic/370 b/tests/generic/370
> index 8adffd2e9650..8101ef42724e 100755
> --- a/tests/generic/370
> +++ b/tests/generic/370
> @@ -22,14 +22,6 @@ _cleanup()
>  [ "$FSTYP" = "btrfs" ] && _fixed_by_kernel_commit 03018e5d8508 \
>      "btrfs: fix swap file activation failure due to extents that used to be shared"
>  
> -# Skip XFS for now because this exposes an issue that is hard to fix.
> -# See the following threads for details about it:
> -#
> -# https://lore.kernel.org/linux-xfs/CAL3q7H7cURmnkJfUUx44HM3q=xKmqHb80eRdisErD_x8rU4+0Q@mail.gmail.com/
> -# https://lore.kernel.org/fstests/dca49a16a7aacdab831b8895bdecbbb52c0e609c.1733928765.git.fdmanana@suse.com/
> -#
> -_exclude_fs xfs
> -
>  _require_scratch_swapfile
>  _require_scratch_reflink
>  _require_cp_reflink
> -- 
> 2.45.2
> 
> 

Re: [PATCH] generic/370: don't exclude XFS

[Darrick J. Wong]

On Mon, Feb 17, 2025 at 07:31:35AM +0100, Christoph Hellwig wrote:
> Skipping tests just because a file system is broken is always a bad idea
> as it hides bugs.
> 
> (Fortunately despite hiding the bug this is now getting fixed in XFS as
>  well).
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/generic/370 | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tests/generic/370 b/tests/generic/370
> index 8adffd2e9650..8101ef42724e 100755
> --- a/tests/generic/370
> +++ b/tests/generic/370
> @@ -22,14 +22,6 @@ _cleanup()
>  [ "$FSTYP" = "btrfs" ] && _fixed_by_kernel_commit 03018e5d8508 \
>      "btrfs: fix swap file activation failure due to extents that used to be shared"
>  
> -# Skip XFS for now because this exposes an issue that is hard to fix.
> -# See the following threads for details about it:
> -#
> -# https://lore.kernel.org/linux-xfs/CAL3q7H7cURmnkJfUUx44HM3q=xKmqHb80eRdisErD_x8rU4+0Q@mail.gmail.com/
> -# https://lore.kernel.org/fstests/dca49a16a7aacdab831b8895bdecbbb52c0e609c.1733928765.git.fdmanana@suse.com/
> -#
> -_exclude_fs xfs

Needs a _fixed_by_xfs_commit XXXXXXXX "xfs: flush inodegc before swapon"

--D

> -
>  _require_scratch_swapfile
>  _require_scratch_reflink
>  _require_cp_reflink
> -- 
> 2.45.2
> 
> 

Re: [PATCH] generic/370: don't exclude XFS

[Zorro Lang]

On Tue, Feb 18, 2025 at 09:39:12AM -0800, Darrick J. Wong wrote:
> On Mon, Feb 17, 2025 at 07:31:35AM +0100, Christoph Hellwig wrote:
> > Skipping tests just because a file system is broken is always a bad idea
> > as it hides bugs.
> > 
> > (Fortunately despite hiding the bug this is now getting fixed in XFS as
> >  well).
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> >  tests/generic/370 | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/tests/generic/370 b/tests/generic/370
> > index 8adffd2e9650..8101ef42724e 100755
> > --- a/tests/generic/370
> > +++ b/tests/generic/370
> > @@ -22,14 +22,6 @@ _cleanup()
> >  [ "$FSTYP" = "btrfs" ] && _fixed_by_kernel_commit 03018e5d8508 \
> >      "btrfs: fix swap file activation failure due to extents that used to be shared"
> >  
> > -# Skip XFS for now because this exposes an issue that is hard to fix.
> > -# See the following threads for details about it:
> > -#
> > -# https://lore.kernel.org/linux-xfs/CAL3q7H7cURmnkJfUUx44HM3q=xKmqHb80eRdisErD_x8rU4+0Q@mail.gmail.com/
> > -# https://lore.kernel.org/fstests/dca49a16a7aacdab831b8895bdecbbb52c0e609c.1733928765.git.fdmanana@suse.com/
> > -#
> > -_exclude_fs xfs
> 
> Needs a _fixed_by_xfs_commit XXXXXXXX "xfs: flush inodegc before swapon"

OK. _fixed_by_xfs_commit is being prepared, not ready:) I'll add:

[ "$FSTYP" = xfs ] && _fixed_by_kernel_commit XXXXXXXX \
	"xfs: flush inodegc before swapon"

Thanks,
Zorro

> 
> --D
> 
> > -
> >  _require_scratch_swapfile
> >  _require_scratch_reflink
> >  _require_cp_reflink
> > -- 
> > 2.45.2
> > 
> > 
>