Re: [RFC 06/12] generic/770: Add atomic write multi-fsblock O_[D]SYNC tests

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Jun 11, 2025 at 03:04:49PM +0530, Ojaswin Mujoo wrote:
> This adds various atomic write multi-fsblock stresst tests
> with mixed mappings and O_SYNC, to ensure the data and metadata
> is atomically persisted even if there is a shutdown.
> 
> Suggested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
> ---
>  tests/generic/770     | 161 ++++++++++++++++++++++++++++++++++++++++++
>  tests/generic/770.out |   2 +
>  2 files changed, 163 insertions(+)
>  create mode 100755 tests/generic/770
>  create mode 100644 tests/generic/770.out
> 
> diff --git a/tests/generic/770 b/tests/generic/770
> new file mode 100755
> index 00000000..2b98b3b3
> --- /dev/null
> +++ b/tests/generic/770
> @@ -0,0 +1,161 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2025 IBM Corporation. All Rights Reserved.
> +#
> +# FS QA Test 770
> +#
> +# Atomic write multi-fsblock data integrity tests with mixed mappings
> +# and O_SYNC
> +#
> +. ./common/preamble
> +. ./common/atomicwrites
> +_begin_fstest auto quick rw atomicwrites
> +
> +_require_scratch_write_atomic_multi_fsblock
> +_require_atomic_write_test_commands

_require_shutdown?

--D

> +
> +_scratch_mkfs >> $seqres.full
> +_scratch_mount >> $seqres.full
> +
> +check_data_integrity() {
> +	actual=$(_hexdump $testfile)
> +	if [[ "$expected" != "$actual" ]]
> +	then
> +		echo "Integrity check failed"
> +		echo "Integrity check failed" >> $seqres.full
> +		echo "# Expected file contents:" >> $seqres.full
> +		echo "$expected" >> $seqres.full
> +		echo "# Actual file contents:" >> $seqres.full
> +		echo "$actual" >> $seqres.full
> +	fi
> +}
> +
> +testfile=$SCRATCH_MNT/testfile
> +touch $testfile
> +
> +awu_max=$(_get_atomic_write_unit_max $testfile)
> +blksz=$(_get_block_size $SCRATCH_MNT)
> +
> +# Create an expected pattern to compare with
> +$XFS_IO_PROG -tc "pwrite -b $awu_max 0 $awu_max" $testfile >> $seqres.full
> +expected=$(_hexdump $testfile)
> +echo "# Expected file contents:" >> $seqres.full
> +echo "$expected" >> $seqres.full
> +
> +echo "# Test 1: Do O_DSYNC atomic write on random mixed mapping (10 iterations):" >> $seqres.full
> +# Calculate how many blocks (e.g. 4K) fit in awu_max (e.g. 64K)
> +num_blocks=$((awu_max / blksz))
> +echo "Testing $num_blocks blocks of $blksz size within $awu_max region" >> $seqres.full
> +
> +operations=("W" "H" "U")
> +
> +# Run 10 iterations of the test
> +for ((iteration=1; iteration<=10; iteration++)); do
> +	echo "=== Mixed Mapping Test Iteration $iteration ===" >> $seqres.full
> +
> +	$XFS_IO_PROG -c "truncate 0" $testfile >> $seqres.full
> +	off=0
> +	mapping=""
> +
> +	for ((i=0; i<num_blocks; i++)); do
> +		index=$((RANDOM % ${#operations[@]}))
> +		map="${operations[$index]}"
> +		mapping="${mapping}${map}"
> +
> +		case "$map" in
> +			"W")
> +				$XFS_IO_PROG -dc "pwrite -S 0x61 -b $blksz $off $blksz" $testfile > /dev/null
> +				;;
> +			"H")
> +				# No operation needed for hole
> +				;;
> +			"U")
> +				$XFS_IO_PROG -c "falloc $off $blksz" $testfile >> /dev/null
> +				;;
> +		esac
> +		off=$((off + blksz))
> +	done
> +
> +	echo "Mixed mapping preparation complete. Full mapping pattern: $mapping" >> $seqres.full
> +
> +	sync $testfile
> +
> +	echo "Performing O_DSYNC atomic write over the entire $awu_max region" >> $seqres.full
> +	bytes_written=$($XFS_IO_PROG -dc "pwrite -DA -V1 -b $awu_max 0 $awu_max" $testfile | \
> +				  grep wrote | awk -F'[/ ]' '{print $2}')
> +
> +	test $bytes_written -eq $awu_max || echo "atomic write len=$awu_max failed"
> +	check_data_integrity
> +	echo "Iteration $iteration completed: OK" >> $seqres.full
> +	echo >> $seqres.full
> +done
> +echo "# Test 1: Do O_SYNC atomic write on random mixed mapping (10 iterations): OK" >> $seqres.full
> +
> +echo >> $seqres.full
> +echo "# Test 2: Do extending O_SYNC atomic writes: " >> $seqres.full
> +bytes_written=$($XFS_IO_PROG -dstc "pwrite -A -V1 -b $awu_max 0 $awu_max" $testfile | \
> +                grep wrote | awk -F'[/ ]' '{print $2}')
> +test $bytes_written -eq $awu_max || echo "atomic write len=$awu_max failed"
> +_scratch_shutdown -v >> $seqres.full
> +_scratch_cycle_mount >>$seqres.full 2>&1 || _fail "remount failed for Test-2"
> +check_data_integrity
> +echo "# Test 2: Do extending O_SYNC atomic writes: OK" >> $seqres.full
> +
> +echo >> $seqres.full
> +echo "# Test 3: Do O_DSYNC atomic write on random mixed mapping with sudden fs shutdown (10 iterations):" >> $seqres.full
> +num_blocks=$((awu_max / blksz))
> +echo "Testing $num_blocks blocks of $blksz size within $awu_max region" >> $seqres.full
> +
> +operations=("W" "H" "U")
> +
> +for ((iteration=1; iteration<=10; iteration++)); do
> +	echo "=== Mixed Mapping Shutdown Test Iteration $iteration ===" >> $seqres.full
> +
> +	$XFS_IO_PROG -c "truncate 0" $testfile >> $seqres.full
> +
> +	off=0
> +	mapping=""
> +
> +	for ((i=0; i<num_blocks; i++)); do
> +		index=$((RANDOM % ${#operations[@]}))
> +		map="${operations[$index]}"
> +		mapping="${mapping}${map}"
> +
> +		case "$map" in
> +			"W")
> +				$XFS_IO_PROG -dc "pwrite -S 0x61 -b $blksz $off $blksz" $testfile > /dev/null
> +				;;
> +			"H")
> +				# No operation needed for hole
> +				;;
> +			"U")
> +				$XFS_IO_PROG -c "falloc $off $blksz" $testfile > /dev/null
> +				;;
> +		esac
> +		off=$((off + blksz))
> +	done
> +
> +	echo "Mixed mapping preparation complete. Full mapping pattern: $mapping" >> $seqres.full
> +
> +	sync $testfile
> +
> +	echo "Performing O_DSYNC atomic write over the entire $awu_max region" >> $seqres.full
> +	bytes_written=$($XFS_IO_PROG -dc "pwrite -DA -V1 -b $awu_max 0 $awu_max" $testfile | \
> +				  grep wrote | awk -F'[/ ]' '{print $2}')
> +
> +	test $bytes_written -eq $awu_max || echo "atomic write len=$awu_max failed"
> +
> +	echo "Shutting down filesystem" >> $seqres.full
> +	_scratch_shutdown -v >> $seqres.full
> +	_scratch_cycle_mount >>$seqres.full 2>&1 || _fail "remount failed for Test-3"
> +	check_data_integrity
> +	echo "Iteration $iteration completed: OK" >> $seqres.full
> +	echo >> $seqres.full
> +done
> +echo "# Test 3: Do O_SYNC atomic write on random mixed mapping with sudden fs shutdown (10 iterations): OK" >> $seqres.full
> +
> +# success, all done
> +echo "Silence is golden"
> +status=0
> +exit
> +
> diff --git a/tests/generic/770.out b/tests/generic/770.out
> new file mode 100644
> index 00000000..17994ed5
> --- /dev/null
> +++ b/tests/generic/770.out
> @@ -0,0 +1,2 @@
> +QA output created by 770
> +Silence is golden
> -- 
> 2.49.0
> 
>