From: Christoph Hellwig <hch@lst.de>
To: zlang@kernel.org
Cc: Yuezhang.Mo@sony.com, fstests@vger.kernel.org
Subject: [PATCH] Revert "generic/730: add _require_scratch_shutdown"
Date: Thu, 24 Jul 2025 09:25:14 +0200 [thread overview]
Message-ID: <20250724072514.3313006-1-hch@lst.de> (raw)
This reverts commit 68c9ac2ad74ba31c02275fcbb11d1cf90f0435b1.
The test does not actually use the xfs_io shutdown functionality,
and it does not use the scatch device. Adding this checks causes
it to fail for setups that do not use SCRATCH_DEV at all.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/generic/730 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/generic/730 b/tests/generic/730
index 6b5d319675f7..6251980e33e1 100755
--- a/tests/generic/730
+++ b/tests/generic/730
@@ -29,7 +29,6 @@ _require_scsi_debug
size=$(_small_fs_size_mb 256)
SCSI_DEBUG_DEV=`_get_scsi_debug_dev 512 512 0 $size`
test -b "$SCSI_DEBUG_DEV" || _notrun "Failed to initialize scsi debug device"
-SCRATCH_DEV=$SCSI_DEBUG_DEV _require_scratch_shutdown
echo "SCSI debug device $SCSI_DEBUG_DEV" >>$seqres.full
run_check _mkfs_dev $SCSI_DEBUG_DEV
--
2.47.2
next reply other threads:[~2025-07-24 7:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 7:25 Christoph Hellwig [this message]
2025-07-25 5:28 ` [PATCH] Revert "generic/730: add _require_scratch_shutdown" Anand Jain
2025-07-25 13:37 ` Zorro Lang
2025-07-29 7:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724072514.3313006-1-hch@lst.de \
--to=hch@lst.de \
--cc=Yuezhang.Mo@sony.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox