Re: [PATCH] Revert "generic/730: add _require_scratch_shutdown"

[Anand Jain <anand.jain@oracle.com>]

On 24/7/25 15:25, Christoph Hellwig wrote:
> This reverts commit 68c9ac2ad74ba31c02275fcbb11d1cf90f0435b1.
> 
> The test does not actually use the xfs_io shutdown functionality,
> and it does not use the scatch device.  Adding this checks causes
> it to fail for setups that do not use SCRATCH_DEV at all.
> 

The test runs on the scsi_debug device but verifies whether the
file system type supports shutdown via the scratch device.

Since mainline Btrfs doesn't support shutdown yet, we see:

---------------------------------
generic/730 3s ... [not run] btrfs does not support shutdown
Ran: generic/730
---------------------------------

With the revert applied, the test case incorrectly runs
and fails on Btrfs.

---------------------------------
generic/730 3s ... - output mismatch (see 
/Volumes/work/ws/fstests/results//generic/730.out.bad)
     --- tests/generic/730.out	2025-07-01 17:41:30.991699629 +0800
     +++ /Volumes/work/ws/fstests/results//generic/730.out.bad 
2025-07-25 13:20:55.690043813 +0800
     @@ -1,2 +1 @@
      QA output created by 730
     -cat: -: Input/output error
     ...
     (Run 'diff -u /Volumes/work/ws/fstests/tests/generic/730.out 
/Volumes/work/ws/fstests/results//generic/730.out.bad'  to see the 
entire diff)
Ran: generic/730
---------------------------------

Thanks.


> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   tests/generic/730 | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tests/generic/730 b/tests/generic/730
> index 6b5d319675f7..6251980e33e1 100755
> --- a/tests/generic/730
> +++ b/tests/generic/730
> @@ -29,7 +29,6 @@ _require_scsi_debug
>   size=$(_small_fs_size_mb 256)
>   SCSI_DEBUG_DEV=`_get_scsi_debug_dev 512 512 0 $size`
>   test -b "$SCSI_DEBUG_DEV" || _notrun "Failed to initialize scsi debug device"
> -SCRATCH_DEV=$SCSI_DEBUG_DEV _require_scratch_shutdown
>   echo "SCSI debug device $SCSI_DEBUG_DEV" >>$seqres.full
>   
>   run_check _mkfs_dev $SCSI_DEBUG_DEV