* [PATCH] generic/645: Confirm availability of free inodes
@ 2026-06-17 5:42 Ojaswin Mujoo
2026-06-25 18:42 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Ojaswin Mujoo @ 2026-06-17 5:42 UTC (permalink / raw)
To: Zorro Lang, fstests; +Cc: Disha Goel
When running generic/645 with ext4 using 64k block size + bigalloc, the
test fails with ENOSPC because the filesystem runs out of inodes before
the test completes.
The test creates approximately 10,001 files, however, in this particular
configuration a standard 5G FS only has around ~5100 inodes resulting in
the ENOSPC failure.
Add a check using _get_free_inode() to verify sufficient inodes are
available before running the test, else skip it.
Reported-by: Disha Goel <disgoel@linux.ibm.com>
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
---
tests/generic/645 | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/generic/645 b/tests/generic/645
index d6eb75e6..944b33db 100755
--- a/tests/generic/645
+++ b/tests/generic/645
@@ -19,6 +19,12 @@ _require_chown
_wants_kernel_commit dacfd001eaf2 \
"fs/mnt_idmapping.c: Return -EINVAL when no map is written"
+_free_inodes=$(_get_free_inode $TEST_DIR)
+if [ $_free_inodes -ne 0 ] && [ $_free_inodes -lt 10001 ]; then
+ _notrun "Insufficient free inodes ($_free_inodes), need at least 10001"
+fi
+
echo "Silence is golden"
$here/src/vfs/vfstest --test-nested-userns \
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] generic/645: Confirm availability of free inodes
2026-06-17 5:42 [PATCH] generic/645: Confirm availability of free inodes Ojaswin Mujoo
@ 2026-06-25 18:42 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2026-06-25 18:42 UTC (permalink / raw)
To: Ojaswin Mujoo; +Cc: Zorro Lang, fstests, Disha Goel
On Wed, Jun 17, 2026 at 11:12:16AM +0530, Ojaswin Mujoo wrote:
> When running generic/645 with ext4 using 64k block size + bigalloc, the
> test fails with ENOSPC because the filesystem runs out of inodes before
> the test completes.
>
> The test creates approximately 10,001 files, however, in this particular
> configuration a standard 5G FS only has around ~5100 inodes resulting in
> the ENOSPC failure.
>
> Add a check using _get_free_inode() to verify sufficient inodes are
> available before running the test, else skip it.
>
> Reported-by: Disha Goel <disgoel@linux.ibm.com>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
> ---
> tests/generic/645 | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tests/generic/645 b/tests/generic/645
> index d6eb75e6..944b33db 100755
> --- a/tests/generic/645
> +++ b/tests/generic/645
> @@ -19,6 +19,12 @@ _require_chown
> _wants_kernel_commit dacfd001eaf2 \
> "fs/mnt_idmapping.c: Return -EINVAL when no map is written"
>
> +_free_inodes=$(_get_free_inode $TEST_DIR)
> +if [ $_free_inodes -ne 0 ] && [ $_free_inodes -lt 10001 ]; then
I'm assuming the > 0 check here is to cover weird filesystems like fat
that don't advertise any inodes? /me wonders if that ought to be a
common helper where we can record that justification:
_require_free_inodes() {
local path="$1"
local nr="$2"
local _free_inodes=$(_get_free_inode "$path")
# Weird filesystems like vfat don't report any inodes, so we
# can't check for sufficient free inodes; IOWs, FAFO.
test "$_free_inodes" -eq 0 && return
test "$_free_inodes" -lt "$nr" && \
_notrun "Insufficient free inodes ($_free_inodes), need at least $nr"
}
_require_free_inodes $TEST_DIR 10001
(maybe clean up the comment a bit)
--D
> + _notrun "Insufficient free inodes ($_free_inodes), need at least 10001"
> +fi
> +
> echo "Silence is golden"
>
> $here/src/vfs/vfstest --test-nested-userns \
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-25 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-17 5:42 [PATCH] generic/645: Confirm availability of free inodes Ojaswin Mujoo
2026-06-25 18:42 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox