* [PATCH v3] common: log mkfs output in _test_streams
@ 2026-07-10 5:22 Christoph Hellwig
2026-07-10 6:11 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2026-07-10 5:22 UTC (permalink / raw)
To: zlang; +Cc: djwong, fstests
Log the mkfs output to allow debugging the mkfs paramters,
especially when mkfs and thus the test fails.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
Changes since v2:
- really append to the log
common/filestreams | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/filestreams b/common/filestreams
index 838b5921520a..cce7599817cd 100644
--- a/common/filestreams
+++ b/common/filestreams
@@ -89,7 +89,7 @@ _test_streams() {
# Skip these tests on zoned file systems as filestreams don't work
# with the zoned allocator, and the operation below would force it into
# the tiny data section only used for metadata anyway.
- _try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
+ _try_scratch_mkfs_xfs >>$seqres.full 2>&1 || _fail "mkfs failed"
_scratch_mount
_require_xfs_scratch_non_zoned
_scratch_unmount 2>/dev/null
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] common: log mkfs output in _test_streams
2026-07-10 5:22 [PATCH v3] common: log mkfs output in _test_streams Christoph Hellwig
@ 2026-07-10 6:11 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2026-07-10 6:11 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: zlang, fstests
On Fri, Jul 10, 2026 at 07:22:08AM +0200, Christoph Hellwig wrote:
> Log the mkfs output to allow debugging the mkfs paramters,
> especially when mkfs and thus the test fails.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>
> Changes since v2:
> - really append to the log
>
> common/filestreams | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/filestreams b/common/filestreams
> index 838b5921520a..cce7599817cd 100644
> --- a/common/filestreams
> +++ b/common/filestreams
> @@ -89,7 +89,7 @@ _test_streams() {
> # Skip these tests on zoned file systems as filestreams don't work
> # with the zoned allocator, and the operation below would force it into
> # the tiny data section only used for metadata anyway.
> - _try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
> + _try_scratch_mkfs_xfs >>$seqres.full 2>&1 || _fail "mkfs failed"
Woot!
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> _scratch_mount
> _require_xfs_scratch_non_zoned
> _scratch_unmount 2>/dev/null
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-10 6:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-10 5:22 [PATCH v3] common: log mkfs output in _test_streams Christoph Hellwig
2026-07-10 6:11 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).