[PATCH] xfs/333: require external scratch device

[PATCH] xfs/333: require external scratch device

[Shin'ichiro Kawasaki]

The test case xfs/333 uses the external scratch device SCRATCH_RTDEV.
When SCRATCH_RTDEV is not specified, the test case fails at
"_require_block_device $SCRATCH_RTDEV". To confirm the requirement, the
test case calls the helper function _require_realtime(). However, it
does not check SCRATCH_RTDEV when the zone type of SCRATCH_DEV is
'none'.

To avoid the failure, ensure the SCRATCH_RTDEV check by calling
_require_external_realtime_device() instead of _require_realtime(). With
this, the test case is skipped when SCRATCH_RTDEV is not specified
regardless of the zone type of SCRATCH_DEV.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 tests/xfs/333 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/333 b/tests/xfs/333
index f2d4077d..7235dc24 100755
--- a/tests/xfs/333
+++ b/tests/xfs/333
@@ -16,7 +16,7 @@ _begin_fstest auto quick rw zone eio
 
 _require_debugfs
 _require_scratch_nocheck
-_require_realtime
+_require_external_realtime_device
 _require_block_device $SCRATCH_RTDEV
 _require_zoned_device $SCRATCH_RTDEV
 _require_command "$BLKZONE_PROG" blkzone
-- 
2.54.0

Re: [PATCH] xfs/333: require external scratch device

[Yao Sang]

Looks good to me.

Reviewed-by: Yao Sang <sangyao@kylinos.cn>

Re: [PATCH] xfs/333: require external scratch device

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>