FS/XFS testing framework
 help / color / mirror / Atom feed
From: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
To: fstests@vger.kernel.org
Cc: Prabhakar Pujeri <prabhakar.pujeri@dell.com>,
	Zorro Lang <zlang@kernel.org>
Subject: [PATCH] common/rc: remove trailing space from _mread() default map_len
Date: Mon, 31 Aug 2026 10:42:05 +0000	[thread overview]
Message-ID: <20260831104206.2284-1-prabhakar.pujeri@dell.com> (raw)

The default map_len expansion contains a space before its closing brace,
so the variable includes trailing whitespace.  Its current unquoted use
tolerates that whitespace, but the value should contain only the computed
length and may be used differently in the future.

Remove the stray space and leave the surrounding expansion unchanged.

Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/rc b/common/rc
index 02bdb31..2db85e5 100644
--- a/common/rc
+++ b/common/rc
@@ -176,7 +176,7 @@ _mread()
 	local file=$1
 	local offset=$2
 	local length=$3
-	local map_len=${4:-$(_round_up_to_page_boundary $(_get_filesize $file)) }
+	local map_len=${4:-$(_round_up_to_page_boundary $(_get_filesize $file))}
 
 	# Some callers expect xfs_io to crash with SIGBUS due to the mread,
 	# causing the shell to print "Bus error" to stderr.  To allow this
-- 
2.55.0


             reply	other threads:[~2026-08-31 10:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 10:42 Prabhakar Pujeri [this message]
2026-08-31 17:21 ` [PATCH] common/rc: remove trailing space from _mread() default map_len Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831104206.2284-1-prabhakar.pujeri@dell.com \
    --to=prabhakar.pujeri@dell.com \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox