Re: [PATCH] common/rc: remove trailing space from _mread() default map_len

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Aug 31, 2026 at 10:42:05AM +0000, Prabhakar Pujeri wrote:
> The default map_len expansion contains a space before its closing brace,
> so the variable includes trailing whitespace.  Its current unquoted use
> tolerates that whitespace, but the value should contain only the computed
> length and may be used differently in the future.
> 
> Remove the stray space and leave the surrounding expansion unchanged.
> 
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>

Heh, whitespace...
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index 02bdb31..2db85e5 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -176,7 +176,7 @@ _mread()
>  	local file=$1
>  	local offset=$2
>  	local length=$3
> -	local map_len=${4:-$(_round_up_to_page_boundary $(_get_filesize $file)) }
> +	local map_len=${4:-$(_round_up_to_page_boundary $(_get_filesize $file))}
>  
>  	# Some callers expect xfs_io to crash with SIGBUS due to the mread,
>  	# causing the shell to print "Bus error" to stderr.  To allow this
> -- 
> 2.55.0
> 
>