Re: [PATCH 4/5] generic/263: enable sub-block reads

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Aug 31, 2026 at 09:51:07AM +0300, Christoph Hellwig wrote:
> The description of generic/263 claims that it tries to exercise sub-block
> direct I/O, but the test currently limits reads to PAGE_SIZE alignment.
> 
> Use the new min_dio_alignment -r option to query the minimal read
> alignment and only limit the read alignment to that.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  tests/generic/263 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/263 b/tests/generic/263
> index 91cfbe5253bd..c456d62ebd43 100755
> --- a/tests/generic/263
> +++ b/tests/generic/263
> @@ -15,7 +15,7 @@ _begin_fstest rw auto quick
>  _require_test
>  _require_odirect
>  
> -psize=`$here/src/feature -s`
> +psize=`$here/src/min_dio_alignment -r $TEST_DIR $TEST_DEV`
>  bsize=`$here/src/min_dio_alignment $TEST_DIR $TEST_DEV`
>  
>  run_fsx -N 10000  -o 8192   -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z
> -- 
> 2.53.0
> 
>