Re: [PATCH 3/5] generic/091: enable sub-block reads

[Zorro Lang <zlang@kernel.org>]

On Mon, Aug 31, 2026 at 10:19:31AM -0700, Darrick J. Wong wrote:
> On Mon, Aug 31, 2026 at 09:51:06AM +0300, Christoph Hellwig wrote:
> > The description of generic/091 claims that it tries to exercise sub-block
> > direct I/O, but the test currently limits reads to PAGE_SIZE alignment.
> > 
> > Use the new min_dio_alignment -r option to query the minimal read
> > alignment and only limit the read alignment to that.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> I've long wondered about why reads are the page size when xfs could
> easily do smaller...

Maybe we should rename psize/PSIZE in _run_fsx_on_file helper (and cases
call *run_fsx* function) as well? Keeping that name for DIO read alignment
doesn't quite match the new semantics introduced by this series.

Thanks,
Zorro

> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> 
> --D
> 
> > ---
> >  tests/generic/091 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/generic/091 b/tests/generic/091
> > index 5cdf04890c0e..b2fba09d39ef 100755
> > --- a/tests/generic/091
> > +++ b/tests/generic/091
> > @@ -15,8 +15,8 @@ _begin_fstest rw auto quick
> >  _require_test
> >  _require_odirect
> >  
> > -psize=`$here/src/feature -s`
> >  bsize=`$here/src/min_dio_alignment $TEST_DIR $TEST_DEV`
> > +psize=`$here/src/min_dio_alignment -r $TEST_DIR $TEST_DEV`
> >  
> >  # fsx usage:
> >  # 
> > -- 
> > 2.53.0
> > 
> >