From: Daniel Linjama <daniel@dev.linjama.com>
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, Qu Wenruo <wqu@suse.com>,
Daniel Linjama <daniel@dev.linjama.com>
Subject: [PATCH 2/2] btrfs: test ENOSPC handling on fsverity rollback
Date: Tue, 15 Sep 2026 08:38:15 +0300 [thread overview]
Message-ID: <20260915053815.307674-2-daniel@dev.linjama.com> (raw)
In-Reply-To: <20260915053815.307674-1-daniel@dev.linjama.com>
Test that the filesystem stays writable when an fsverity enable and its
rollback run out of space on a small mixed block group filesystem, and
that it still mounts afterwards with no verity or orphan items left behind.
The -ENOSPC counterpart of btrfs/354.
This exercises a bug fixed by the kernel patch with subject:
"btrfs: handle lack of space when cleaning up verity items"
Assisted-by: LLM
Signed-off-by: Daniel Linjama <daniel@dev.linjama.com>
---
tests/btrfs/355 | 119 ++++++++++++++++++++++++++++++++++++++++++++
tests/btrfs/355.out | 2 +
2 files changed, 121 insertions(+)
create mode 100755 tests/btrfs/355
create mode 100644 tests/btrfs/355.out
diff --git a/tests/btrfs/355 b/tests/btrfs/355
new file mode 100755
index 0000000..5f13c5b
--- /dev/null
+++ b/tests/btrfs/355
@@ -0,0 +1,119 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2026 Daniel Linjama. All Rights Reserved.
+#
+# FS QA Test 355
+#
+# Test that a failed fsverity enable on a full filesystem leaves the
+# filesystem usable. The -ENOSPC counterpart of btrfs/354.
+#
+. ./common/preamble
+_begin_fstest auto quick verity enospc
+
+# Override the default cleanup function.
+_cleanup()
+{
+ cd /
+ _restore_fsverity_signatures
+ rm -f $tmp.*
+}
+
+# Import common functions.
+. ./common/filter
+. ./common/verity
+
+# real QA test starts here
+
+_require_scratch_verity
+_require_btrfs_command inspect-internal dump-tree
+_require_xfs_io_command "falloc"
+_require_no_compress
+_require_scratch_size $((1024 * 1024))
+_disable_fsverity_signatures
+
+_fixed_by_kernel_commit xxxxxxxxxxxx \
+ "btrfs: handle lack of space when cleaning up verity items"
+
+target=$SCRATCH_MNT/target
+
+prepare()
+{
+ # Mixed block groups, so filling with data starves metadata too.
+ _scratch_mkfs --mixed -b 1G &>> $seqres.full || _fail "mkfs failed"
+ _scratch_mount
+}
+
+create_target()
+{
+ $XFS_IO_PROG -f -c "pwrite -S 0 -b 1m 0 512m" $target >> $seqres.full 2>&1
+ sync
+}
+
+fill_fs()
+{
+ local i=0
+
+ while $XFS_IO_PROG -f -c "falloc 0 2m" $SCRATCH_MNT/filler.$i &>/dev/null; do
+ i=$((i + 1))
+ [ $i -gt 1000 ] && break
+ done
+ echo "fillers written: $i" >> $seqres.full
+ # Room for the enable to start, not to finish.
+ rm -f $SCRATCH_MNT/filler.$((i - 1))
+ sync
+ $BTRFS_UTIL_PROG filesystem usage $SCRATCH_MNT >> $seqres.full 2>&1
+}
+
+enable_fsverity()
+{
+ if _fsv_enable $target >> $seqres.full 2>&1; then
+ _notrun "could not fill the filesystem, verity enable succeeded"
+ fi
+}
+
+check_rollback()
+{
+ # Deleting a filler needs no new space, it fails only if the fs went read-only.
+ rm -f $SCRATCH_MNT/filler.0 2>> $seqres.full || \
+ echo "filesystem was forced read-only by the failed verity enable"
+ if $FSVERITY_PROG measure $target >> $seqres.full 2>&1; then
+ echo "verity is enabled on the target after a failed enable"
+ fi
+}
+
+check_remount()
+{
+ _scratch_unmount
+ _try_scratch_mount >> $seqres.full 2>&1 || \
+ _fail "cannot mount the filesystem after the failed verity enable"
+ dd if=$target of=/dev/null bs=1M count=1 status=none 2>> $seqres.full || \
+ echo "cannot read the target file after the failed verity enable"
+ _scratch_unmount
+}
+
+check_leftover_items()
+{
+ local dump=$($BTRFS_UTIL_PROG inspect-internal dump-tree -t 5 $SCRATCH_DEV)
+ local verity_items=$(echo "$dump" | grep -c 'VERITY_\(DESC\|MERKLE\)_ITEM')
+ local orphans=$(echo "$dump" | grep -c 'ORPHAN_ITEM')
+
+ echo "$dump" >> $seqres.full
+ [ "$verity_items" -eq 0 ] || \
+ echo "$verity_items verity items left behind by the failed enable"
+ [ "$orphans" -eq 0 ] || \
+ echo "$orphans orphan items left behind by the failed enable"
+}
+
+prepare
+create_target
+fill_fs
+enable_fsverity
+check_rollback
+check_remount
+check_leftover_items
+
+echo "Silence is golden"
+
+# success, all done
+status=0
+exit
diff --git a/tests/btrfs/355.out b/tests/btrfs/355.out
new file mode 100644
index 0000000..4e4c5e9
--- /dev/null
+++ b/tests/btrfs/355.out
@@ -0,0 +1,2 @@
+QA output created by 355
+Silence is golden
--
2.55.0
next prev parent reply other threads:[~2026-09-15 5:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 5:38 [PATCH 1/2] btrfs: test qgroup limit handling on fsverity rollback Daniel Linjama
2026-09-15 5:38 ` Daniel Linjama [this message]
2026-09-15 5:50 ` Qu Wenruo
2026-09-16 5:12 ` Daniel Linjama
2026-09-16 5:34 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915053815.307674-2-daniel@dev.linjama.com \
--to=daniel@dev.linjama.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox