From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Daniel Linjama <daniel@dev.linjama.com>, Qu Wenruo <wqu@suse.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: test qgroup limit handling on fsverity rollback
Date: Wed, 16 Sep 2026 15:04:31 +0930 [thread overview]
Message-ID: <b33b2a2c-dd03-4741-9f3e-1e124bd7ecef@gmx.com> (raw)
In-Reply-To: <20260916051240.585268-1-daniel@dev.linjama.com>
在 2026/9/16 14:42, Daniel Linjama 写道:
> On 2026/9/15 15:20, Qu Wenruo wrote:
>>> +_require_btrfs_command quota
>>
>> _require_btrfs_command quota rescan -w
>
> Will do in v2.
The better solution is _require_qgroup_rescan(), which has the extra
checks for -W and -w options built-in.
>
>>> + _qgroup_rescan $SCRATCH_MNT >> $seqres.full 2>&1
>>
>> Use "-w" option, or the rescan may not finish in time before the workload.
>
> _qgroup_rescan already runs "btrfs quota rescan -w", so the test waits
> for the rescan. I'll keep the helper.
>
>>> + while dd if=/dev/zero of=$subv/filler.$i bs=1M count=4 status=none 2>/dev/null; do
>> [...]
>> You can just do a 40MiB write (which should fail halfway), sync, retry
>> the write until the write failed to write any bytes.
>
> Will do in v2, with xfs_io instead of dd as the other tests do. A single
> write turned out to be enough: after it fails with -EDQUOT and a sync,
> nothing more fits, so there is no retry loop.
>
> Thanks,
> Daniel
prev parent reply other threads:[~2026-09-16 5:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 5:38 [PATCH 1/2] btrfs: test qgroup limit handling on fsverity rollback Daniel Linjama
2026-09-15 5:38 ` [PATCH 2/2] btrfs: test ENOSPC " Daniel Linjama
2026-09-15 5:50 ` [PATCH 1/2] btrfs: test qgroup limit " Qu Wenruo
2026-09-16 5:12 ` Daniel Linjama
2026-09-16 5:34 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b33b2a2c-dd03-4741-9f3e-1e124bd7ecef@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=daniel@dev.linjama.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox