Re: [PATCH v2 0/2] Add support for using liburing xattr

[Stefan Roesch <shr@fb.com>]

On 12/12/21 7:17 AM, Eryu Guan wrote:
> On Tue, Nov 30, 2021 at 09:52:00PM -0800, Stefan Roesch wrote:
>> This adds support for using the xattr implementation in liburing.
>>
>> Patch 1: fstress: add suport for using liburing setxattr
>>   Uses the liburing setxattr implementation in fsstress.
>>
>> Patch 2: fstress: add suport for using liburing getxattr
>>   Uses the liburing getxattr implementation in fsstress.
>>
>> There are two additional patch series related to this:
>> - io_uring: add xattr support
>> - liburing: add xattr support
> 
> Patches look fine to me overall, just one minor issue in patch 2.
> 
> But I'd like to firstly make sure the above patches for kernel and
> liburing will be accepted, so we don't merge tests for features that are
> never upstreamed. They don't have to be actually upstreamed, as long as
> the maintainers don't reject the new features.
> 
> And fsstress.c has been updated, would you please rebase & resend by
> then?
> 

I fixed the tab issue and rebased to version 4.

> Thanks,
> Eryu
> 
>>
>>
>> Signed-off-by: Stefan Roesch <shr@fb.com>
>> base-commit: 2050356437e3576673ec5ead79ad72eb619f0d72
>> ---
>> V2: - Introduce dedicated functions for uring getxattr and
>>       uring setxattr, so they are not automatically linked
>>       in if liburing is available.
>>
>>
>> Stefan Roesch (2):
>>   fstress: add suport for using liburing setxattr
>>   fstress: add suport for using liburing getxattr
>>
>>  ltp/fsstress.c | 122 ++++++++++++++++++++++++++++++++++++++++++++++---
>>  1 file changed, 116 insertions(+), 6 deletions(-)
>>
>> -- 
>> 2.30.2