public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: Stefan Roesch <shr@fb.com>
Cc: fstests@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 0/2] Add support for using liburing xattr
Date: Sun, 12 Dec 2021 23:17:06 +0800	[thread overview]
Message-ID: <YbYScqspQfzeqPEn@desktop> (raw)
In-Reply-To: <20211201055202.3142034-1-shr@fb.com>

On Tue, Nov 30, 2021 at 09:52:00PM -0800, Stefan Roesch wrote:
> This adds support for using the xattr implementation in liburing.
> 
> Patch 1: fstress: add suport for using liburing setxattr
>   Uses the liburing setxattr implementation in fsstress.
> 
> Patch 2: fstress: add suport for using liburing getxattr
>   Uses the liburing getxattr implementation in fsstress.
> 
> There are two additional patch series related to this:
> - io_uring: add xattr support
> - liburing: add xattr support

Patches look fine to me overall, just one minor issue in patch 2.

But I'd like to firstly make sure the above patches for kernel and
liburing will be accepted, so we don't merge tests for features that are
never upstreamed. They don't have to be actually upstreamed, as long as
the maintainers don't reject the new features.

And fsstress.c has been updated, would you please rebase & resend by
then?

Thanks,
Eryu

> 
> 
> Signed-off-by: Stefan Roesch <shr@fb.com>
> base-commit: 2050356437e3576673ec5ead79ad72eb619f0d72
> ---
> V2: - Introduce dedicated functions for uring getxattr and
>       uring setxattr, so they are not automatically linked
>       in if liburing is available.
> 
> 
> Stefan Roesch (2):
>   fstress: add suport for using liburing setxattr
>   fstress: add suport for using liburing getxattr
> 
>  ltp/fsstress.c | 122 ++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 116 insertions(+), 6 deletions(-)
> 
> -- 
> 2.30.2

  parent reply	other threads:[~2021-12-12 15:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01  5:52 [PATCH v2 0/2] Add support for using liburing xattr Stefan Roesch
2021-12-01  5:52 ` [PATCH v2 1/2] fstress: add suport for using liburing setxattr Stefan Roesch
2021-12-16  7:30   ` Zorro Lang
2021-12-16 17:28     ` Stefan Roesch
2021-12-01  5:52 ` [PATCH v2 2/2] fstress: add suport for using liburing getxattr Stefan Roesch
2021-12-12 15:10   ` Eryu Guan
2021-12-16 18:43     ` Stefan Roesch
2021-12-12 15:17 ` Eryu Guan [this message]
2021-12-16 18:48   ` [PATCH v2 0/2] Add support for using liburing xattr Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbYScqspQfzeqPEn@desktop \
    --to=guaneryu@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=shr@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox