From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Christian Brauner <brauner@kernel.org>, Zorro Lang <zlang@redhat.com>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>
Subject: Re: [PATCH] generic/193: add to perms group
Date: Tue, 18 Oct 2022 02:27:50 +0000 [thread overview]
Message-ID: <3d37367c-9363-e192-163b-4daba2c73a0d@fujitsu.com> (raw)
In-Reply-To: <20221017150408.ddda2hpggg5x7ljh@wittgenstein>
on 2022/10/17 23:04, Christian Brauner wrote:
> On Mon, Oct 17, 2022 at 09:29:14PM +0800, Zorro Lang wrote:
>> On Mon, Oct 17, 2022 at 10:01:13AM +0000, xuyang2018.jy@fujitsu.com wrote:
>>>
>>>
>>> on 2022/10/17 17:53, Christian Brauner wrote:
>>>> This test changes permissions and specifically tests for setuid and
>>>> setgid bits to be dropped or kept. It really needs to be run when -g
>>>> perms is specified.
>>>
>>> Yes, Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>>>
>>> ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should
>>> also add perms group.
>>
>> OK, if Christian agrees with this point and would like to help that, please
>> help to check and add "perms" to more proper cases in one patch.
>
> I think that's a good idea. Yang, would you be open to sending a patch
> to add all these test to the "perms" group in one go?
Of course, I will look for more case to add perms group in one patch as
zorro and you sugguested.
Best Regards
Yang Xu
prev parent reply other threads:[~2022-10-18 2:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 9:53 [PATCH] generic/193: add to perms group Christian Brauner
2022-10-17 10:01 ` xuyang2018.jy
2022-10-17 13:29 ` Zorro Lang
2022-10-17 15:04 ` Christian Brauner
2022-10-18 2:27 ` xuyang2018.jy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d37367c-9363-e192-163b-4daba2c73a0d@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=brauner@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox