From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Christian Brauner <brauner@kernel.org>,
Zorro Lang <zlang@redhat.com>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>
Subject: Re: [PATCH] generic/193: add to perms group
Date: Mon, 17 Oct 2022 10:01:13 +0000 [thread overview]
Message-ID: <7eb737f8-5fb2-97ac-6ad7-eb1ce8a59f30@fujitsu.com> (raw)
In-Reply-To: <20221017095311.68280-1-brauner@kernel.org>
on 2022/10/17 17:53, Christian Brauner wrote:
> This test changes permissions and specifically tests for setuid and
> setgid bits to be dropped or kept. It really needs to be run when -g
> perms is specified.
Yes, Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should
also add perms group.
Best Regards
Yang Xu
>
> Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
> ---
> tests/generic/193 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/193 b/tests/generic/193
> index ddaff69b..e2710b07 100755
> --- a/tests/generic/193
> +++ b/tests/generic/193
> @@ -7,7 +7,7 @@
> # Test permission checks in ->setattr
> #
> . ./common/preamble
> -_begin_fstest metadata auto quick
> +_begin_fstest metadata auto quick perms
>
> _register_cleanup "_cleanup_files"
> tag="added by qa $seq"
>
> base-commit: a75c5f50584e03ca7862ad51f48efd2d524d1dc5
next prev parent reply other threads:[~2022-10-17 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 9:53 [PATCH] generic/193: add to perms group Christian Brauner
2022-10-17 10:01 ` xuyang2018.jy [this message]
2022-10-17 13:29 ` Zorro Lang
2022-10-17 15:04 ` Christian Brauner
2022-10-18 2:27 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eb737f8-5fb2-97ac-6ad7-eb1ce8a59f30@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=brauner@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox