[PATCH] fstests: require no compression for generic/352

[PATCH] fstests: require no compression for generic/352

[Josef Bacik]

Our CI has been failing on this test for compression since 0fc226e7
("fstests: generic/352 should accomodate other pwrite behaviors").  This
is because we changed the size of the initial write down to 4k, and we
write a repeatable pattern.  With compression on btrfs this results in
an inline extent, and when you reflink an inline extent this just turns
it into full on copies instead of a reflink.

As this isn't a bug with compression, it's just not well aligned with
how compression interacts with the allocation of space, simply exclude
this test from running when you have compression enabled.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 tests/generic/352 | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/generic/352 b/tests/generic/352
index acc17dac..3a18f076 100755
--- a/tests/generic/352
+++ b/tests/generic/352
@@ -25,6 +25,10 @@ _supported_fs generic
 _require_scratch_reflink
 _require_xfs_io_command "fiemap"
 
+# The size is too small, this will result in an inline extent and then reflink
+# will simply be a copy on btrfs, so exclude compression.
+ _require_no_compress
+
 _scratch_mkfs > /dev/null 2>&1
 _scratch_mount
 
-- 
2.41.0

Re: [PATCH] fstests: require no compression for generic/352

[Qu Wenruo]

On 2023/11/4 06:03, Josef Bacik wrote:
> Our CI has been failing on this test for compression since 0fc226e7
> ("fstests: generic/352 should accomodate other pwrite behaviors").  This
> is because we changed the size of the initial write down to 4k, and we
> write a repeatable pattern.  With compression on btrfs this results in
> an inline extent, and when you reflink an inline extent this just turns
> it into full on copies instead of a reflink.
>
> As this isn't a bug with compression, it's just not well aligned with
> how compression interacts with the allocation of space, simply exclude
> this test from running when you have compression enabled.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
> ---
>   tests/generic/352 | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/tests/generic/352 b/tests/generic/352
> index acc17dac..3a18f076 100755
> --- a/tests/generic/352
> +++ b/tests/generic/352
> @@ -25,6 +25,10 @@ _supported_fs generic
>   _require_scratch_reflink
>   _require_xfs_io_command "fiemap"
>
> +# The size is too small, this will result in an inline extent and then reflink
> +# will simply be a copy on btrfs, so exclude compression.
> + _require_no_compress
> +
>   _scratch_mkfs > /dev/null 2>&1
>   _scratch_mount
>