* generic/076 cleanup
@ 2014-08-04 11:19 Omer Caspi
2014-08-04 15:12 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Omer Caspi @ 2014-08-04 11:19 UTC (permalink / raw)
To: fstests; +Cc: Boaz
While running some tests from the xfstests suite (quick group), I noticed
that generic test 076 doesn't clean after itself. Specifically, a couple
of directories (p1 and p2) remain on $TEST_DIR once the test is completed.
To my understanding, a test should cleanup the files it had created, so I
added a rm command to test's _cleanup function to fix it, which seems to
be OK, but I thought I'll check: is there a reason for these directories
to remain there after the test completion?
Omer
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: generic/076 cleanup
2014-08-04 11:19 generic/076 cleanup Omer Caspi
@ 2014-08-04 15:12 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2014-08-04 15:12 UTC (permalink / raw)
To: Omer Caspi, fstests; +Cc: Boaz
On 8/4/14, 6:19 AM, Omer Caspi wrote:
> While running some tests from the xfstests suite (quick group), I noticed
> that generic test 076 doesn't clean after itself. Specifically, a couple
> of directories (p1 and p2) remain on $TEST_DIR once the test is completed.
> To my understanding, a test should cleanup the files it had created, so I
> added a rm command to test's _cleanup function to fix it, which seems to
> be OK, but I thought I'll check: is there a reason for these directories
> to remain there after the test completion?
>
> Omer
the test device is supposed to age, so leaving things lying around there
after the test has run is expected, and fine.
_cleanup is more about removing tmpfiles, killing any spawned threads,
etc - not about cleaning up the test device.
-Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-04 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 11:19 generic/076 cleanup Omer Caspi
2014-08-04 15:12 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox