FS/XFS testing framework
 help / color / mirror / Atom feed
* [PATCH] xfs/111: fix cp of missing file
@ 2014-12-20  7:50 Xing Gu
  2014-12-21 22:09 ` Dave Chinner
  2014-12-22  8:41 ` [PATCH v2] " Xing Gu
  0 siblings, 2 replies; 4+ messages in thread
From: Xing Gu @ 2014-12-20  7:50 UTC (permalink / raw)
  To: fstests; +Cc: Xing Gu

After installing the test suite, src directory only contains binary
programs in the final building directory. Here executing "cp src/itrash.c
$SCRATCH_MNT/${I}" will output "cp: cannot stat 'src/itrash.c': No
such file or directory" error message. Fix it.

Signed-off-by: Xing Gu <gux.fnst@cn.fujitsu.com>
---
 tests/xfs/111 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/111 b/tests/xfs/111
index bedead8..a900184 100755
--- a/tests/xfs/111
+++ b/tests/xfs/111
@@ -53,7 +53,7 @@ echo Create some files
 I=0
 while [ $I -lt 1000 ]
 do
-    cp src/itrash.c $SCRATCH_MNT/${I}
+    cp src/itrash* $SCRATCH_MNT/${I}
     let I=$I+1
 done
 umount $SCRATCH_DEV
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] xfs/111: fix cp of missing file
  2014-12-20  7:50 [PATCH] xfs/111: fix cp of missing file Xing Gu
@ 2014-12-21 22:09 ` Dave Chinner
  2014-12-22  2:09   ` gux.fnst
  2014-12-22  8:41 ` [PATCH v2] " Xing Gu
  1 sibling, 1 reply; 4+ messages in thread
From: Dave Chinner @ 2014-12-21 22:09 UTC (permalink / raw)
  To: Xing Gu; +Cc: fstests

On Sat, Dec 20, 2014 at 03:50:02PM +0800, Xing Gu wrote:
> After installing the test suite, src directory only contains binary
> programs in the final building directory. Here executing "cp src/itrash.c
> $SCRATCH_MNT/${I}" will output "cp: cannot stat 'src/itrash.c': No
> such file or directory" error message. Fix it.
> 
> Signed-off-by: Xing Gu <gux.fnst@cn.fujitsu.com>
> ---
>  tests/xfs/111 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/111 b/tests/xfs/111
> index bedead8..a900184 100755
> --- a/tests/xfs/111
> +++ b/tests/xfs/111
> @@ -53,7 +53,7 @@ echo Create some files
>  I=0
>  while [ $I -lt 1000 ]
>  do
> -    cp src/itrash.c $SCRATCH_MNT/${I}
> +    cp src/itrash* $SCRATCH_MNT/${I}
>      let I=$I+1
>  done
>  umount $SCRATCH_DEV

Just use $XFS_IO_PROG to create the files.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xfs/111: fix cp of missing file
  2014-12-21 22:09 ` Dave Chinner
@ 2014-12-22  2:09   ` gux.fnst
  0 siblings, 0 replies; 4+ messages in thread
From: gux.fnst @ 2014-12-22  2:09 UTC (permalink / raw)
  To: Dave Chinner; +Cc: fstests



On 12/22/2014 06:09 AM, Dave Chinner wrote:
> On Sat, Dec 20, 2014 at 03:50:02PM +0800, Xing Gu wrote:
>> After installing the test suite, src directory only contains binary
>> programs in the final building directory. Here executing "cp src/itrash.c
>> $SCRATCH_MNT/${I}" will output "cp: cannot stat 'src/itrash.c': No
>> such file or directory" error message. Fix it.
>>
>> Signed-off-by: Xing Gu <gux.fnst@cn.fujitsu.com>
>> ---
>>   tests/xfs/111 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/xfs/111 b/tests/xfs/111
>> index bedead8..a900184 100755
>> --- a/tests/xfs/111
>> +++ b/tests/xfs/111
>> @@ -53,7 +53,7 @@ echo Create some files
>>   I=0
>>   while [ $I -lt 1000 ]
>>   do
>> -    cp src/itrash.c $SCRATCH_MNT/${I}
>> +    cp src/itrash* $SCRATCH_MNT/${I}
>>       let I=$I+1
>>   done
>>   umount $SCRATCH_DEV
>
> Just use $XFS_IO_PROG to create the files.
>

Got it. Thanks!

regards,
Xing Gu

> Cheers,
>
> Dave.
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] xfs/111: fix cp of missing file
  2014-12-20  7:50 [PATCH] xfs/111: fix cp of missing file Xing Gu
  2014-12-21 22:09 ` Dave Chinner
@ 2014-12-22  8:41 ` Xing Gu
  1 sibling, 0 replies; 4+ messages in thread
From: Xing Gu @ 2014-12-22  8:41 UTC (permalink / raw)
  To: fstests; +Cc: Xing Gu

After installing the test suite, src directory only contains binary
programs in the final building directory. Here executing "cp src/itrash.c
$SCRATCH_MNT/${I}" will output "cp: cannot stat 'src/itrash.c': No
such file or directory" error message. Fix it.

Signed-off-by: Xing Gu <gux.fnst@cn.fujitsu.com>
---
 tests/xfs/111 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/111 b/tests/xfs/111
index bedead8..f33f339 100755
--- a/tests/xfs/111
+++ b/tests/xfs/111
@@ -53,7 +53,7 @@ echo Create some files
 I=0
 while [ $I -lt 1000 ]
 do
-    cp src/itrash.c $SCRATCH_MNT/${I}
+    $XFS_IO_PROG -f -c "pwrite 0 512" $SCRATCH_MNT/${I} > /dev/null
     let I=$I+1
 done
 umount $SCRATCH_DEV
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-12-22  8:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-20  7:50 [PATCH] xfs/111: fix cp of missing file Xing Gu
2014-12-21 22:09 ` Dave Chinner
2014-12-22  2:09   ` gux.fnst
2014-12-22  8:41 ` [PATCH v2] " Xing Gu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox