FS/XFS testing framework
 help / color / mirror / Atom feed
* Re: [PATCH] xfstests: f2fs support
       [not found] <1401717572-21731-1-git-send-email-jaegeuk@kernel.org>
@ 2014-12-22 18:45 ` Eric Sandeen
  2014-12-22 21:35   ` Dave Chinner
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2014-12-22 18:45 UTC (permalink / raw)
  To: jaegeuk, Dave Chinner; +Cc: fstests, linux-f2fs-devel

(redirecting to the new fstests list)

Dave, this got a review from Lukas, and seems fine.
Can you pull it in?

Thanks,
-Eric

On 6/2/14 8:59 AM, jaegeuk@kernel.org wrote:
> From: Jaegeuk Kim <jaegeuk@kernel.org>
> 
> This patch adds to support f2fs file system.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  common/config | 7 +++++++
>  common/rc     | 6 ++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/common/config b/common/config
> index 0dbf0b9..0607294 100644
> --- a/common/config
> +++ b/common/config
> @@ -210,6 +210,7 @@ case "$HOSTOS" in
>          export MKFS_XFS_PROG="`set_prog_path mkfs.xfs`"
>          export MKFS_UDF_PROG="`set_prog_path mkudffs`"
>          export MKFS_BTRFS_PROG="`set_btrfs_mkfs_prog_path_with_opts`"
> +        export MKFS_F2FS_PROG="`set_prog_path mkfs.f2fs`"
>          export BTRFS_UTIL_PROG="`set_prog_path btrfs`"
>          export BTRFS_SHOW_SUPER_PROG="`set_prog_path btrfs-show-super`"
>          export XFS_FSR_PROG="`set_prog_path xfs_fsr`"
> @@ -241,6 +242,9 @@ _mount_opts()
>  		# acls & xattrs aren't turned on by default on ext$FOO
>  		export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
>  		;;
> +	f2fs)
> +		export MOUNT_OPTIONS="-o acl,user_xattr $F2FS_MOUNT_OPTIONS"
> +		;;
>  	reiserfs)
>  		# acls & xattrs aren't turned on by default on reiserfs
>  		export MOUNT_OPTIONS="-o acl,user_xattr $REISERFS_MOUNT_OPTIONS"
> @@ -295,6 +299,9 @@ _fsck_opts()
>  	reiserfs)
>  		export FSCK_OPTIONS="--yes"
>  		;;
> +	f2fs)
> +		export FSCK_OPTIONS=""
> +		;;
>  	*)
>  		export FSCK_OPTIONS="-n"
>  		;;
> diff --git a/common/rc b/common/rc
> index f27ee53..fcdabfe 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -105,6 +105,9 @@ case "$FSTYP" in
>      btrfs)
>  	 [ "$MKFS_BTRFS_PROG" = "" ] && _fatal "mkfs.btrfs not found"
>  	 ;;
> +    f2fs)
> +	 [ "$MKFS_F2FS_PROG" = "" ] && _fatal "mkfs.f2fs not found"
> +	 ;;
>      nfs)
>  	 ;;
>  esac
> @@ -511,6 +514,9 @@ _scratch_mkfs()
>      tmpfs)
>  	# do nothing for tmpfs
>  	;;
> +    f2fs)
> +        $MKFS_F2FS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
> +	;;
>      *)
>  	yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
>  	;;
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfstests: f2fs support
  2014-12-22 18:45 ` [PATCH] xfstests: f2fs support Eric Sandeen
@ 2014-12-22 21:35   ` Dave Chinner
  2014-12-22 22:29     ` Jaegeuk Kim
  0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2014-12-22 21:35 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: jaegeuk, fstests, linux-f2fs-devel

On Mon, Dec 22, 2014 at 12:45:44PM -0600, Eric Sandeen wrote:
> (redirecting to the new fstests list)
> 
> Dave, this got a review from Lukas, and seems fine.
> Can you pull it in?

Can it be reposted so I can pull it in directly? quoted patches
aren't recognised by any tool...

Cheers,

Dave.
> 
> Thanks,
> -Eric
> 
> On 6/2/14 8:59 AM, jaegeuk@kernel.org wrote:
> > From: Jaegeuk Kim <jaegeuk@kernel.org>
> > 
> > This patch adds to support f2fs file system.
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >  common/config | 7 +++++++
> >  common/rc     | 6 ++++++
> >  2 files changed, 13 insertions(+)
> > 
> > diff --git a/common/config b/common/config
> > index 0dbf0b9..0607294 100644
> > --- a/common/config
> > +++ b/common/config
> > @@ -210,6 +210,7 @@ case "$HOSTOS" in
> >          export MKFS_XFS_PROG="`set_prog_path mkfs.xfs`"
> >          export MKFS_UDF_PROG="`set_prog_path mkudffs`"
> >          export MKFS_BTRFS_PROG="`set_btrfs_mkfs_prog_path_with_opts`"
> > +        export MKFS_F2FS_PROG="`set_prog_path mkfs.f2fs`"
> >          export BTRFS_UTIL_PROG="`set_prog_path btrfs`"
> >          export BTRFS_SHOW_SUPER_PROG="`set_prog_path btrfs-show-super`"
> >          export XFS_FSR_PROG="`set_prog_path xfs_fsr`"
> > @@ -241,6 +242,9 @@ _mount_opts()
> >  		# acls & xattrs aren't turned on by default on ext$FOO
> >  		export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
> >  		;;
> > +	f2fs)
> > +		export MOUNT_OPTIONS="-o acl,user_xattr $F2FS_MOUNT_OPTIONS"
> > +		;;
> >  	reiserfs)
> >  		# acls & xattrs aren't turned on by default on reiserfs
> >  		export MOUNT_OPTIONS="-o acl,user_xattr $REISERFS_MOUNT_OPTIONS"
> > @@ -295,6 +299,9 @@ _fsck_opts()
> >  	reiserfs)
> >  		export FSCK_OPTIONS="--yes"
> >  		;;
> > +	f2fs)
> > +		export FSCK_OPTIONS=""
> > +		;;
> >  	*)
> >  		export FSCK_OPTIONS="-n"
> >  		;;
> > diff --git a/common/rc b/common/rc
> > index f27ee53..fcdabfe 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -105,6 +105,9 @@ case "$FSTYP" in
> >      btrfs)
> >  	 [ "$MKFS_BTRFS_PROG" = "" ] && _fatal "mkfs.btrfs not found"
> >  	 ;;
> > +    f2fs)
> > +	 [ "$MKFS_F2FS_PROG" = "" ] && _fatal "mkfs.f2fs not found"
> > +	 ;;
> >      nfs)
> >  	 ;;
> >  esac
> > @@ -511,6 +514,9 @@ _scratch_mkfs()
> >      tmpfs)
> >  	# do nothing for tmpfs
> >  	;;
> > +    f2fs)
> > +        $MKFS_F2FS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
> > +	;;
> >      *)
> >  	yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
> >  	;;
> > 
> 
> 

-- 
Dave Chinner
david@fromorbit.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfstests: f2fs support
  2014-12-22 21:35   ` Dave Chinner
@ 2014-12-22 22:29     ` Jaegeuk Kim
  0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2014-12-22 22:29 UTC (permalink / raw)
  To: Dave Chinner; +Cc: Eric Sandeen, fstests, linux-f2fs-devel

Thanks Eric,
I totally forgot this patch to repost.

Dave,
Could you please apply this patch?

Thanks,

-- >8 --
>From 86eb93921e1ce28e965e3152ac7066b45bccb4eb Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim <jaegeuk@kernel.org>
Date: Mon, 2 Jun 2014 20:09:19 +0900
Subject: [PATCH] xfstests: f2fs support

This patch adds to support f2fs file system.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
---
 common/config | 7 +++++++
 common/rc     | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/common/config b/common/config
index e9971fd..06bdee2 100644
--- a/common/config
+++ b/common/config
@@ -219,6 +219,7 @@ case "$HOSTOS" in
         export MKFS_EXT4_PROG="`set_prog_path mkfs.ext4`"
         export MKFS_UDF_PROG="`set_prog_path mkudffs`"
         export MKFS_BTRFS_PROG="`set_btrfs_mkfs_prog_path_with_opts`"
+        export MKFS_F2FS_PROG="`set_prog_path mkfs.f2fs`"
         export BTRFS_UTIL_PROG="`set_prog_path btrfs`"
         export BTRFS_SHOW_SUPER_PROG="`set_prog_path btrfs-show-super`"
         export XFS_FSR_PROG="`set_prog_path xfs_fsr`"
@@ -254,6 +255,9 @@ _mount_opts()
 		# acls & xattrs aren't turned on by default on ext$FOO
 		export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
 		;;
+	f2fs)
+		export MOUNT_OPTIONS="-o acl,user_xattr $F2FS_MOUNT_OPTIONS"
+		;;
 	reiserfs)
 		# acls & xattrs aren't turned on by default on reiserfs
 		export MOUNT_OPTIONS="-o acl,user_xattr $REISERFS_MOUNT_OPTIONS"
@@ -322,6 +326,9 @@ _fsck_opts()
 	reiserfs)
 		export FSCK_OPTIONS="--yes"
 		;;
+	f2fs)
+		export FSCK_OPTIONS=""
+		;;
 	*)
 		export FSCK_OPTIONS="-n"
 		;;
diff --git a/common/rc b/common/rc
index 82a91c2..a39885d 100644
--- a/common/rc
+++ b/common/rc
@@ -108,6 +108,9 @@ case "$FSTYP" in
     ext4)
 	 [ "$MKFS_EXT4_PROG" = "" ] && _fatal "mkfs.ext4 not found"
 	 ;;
+    f2fs)
+	 [ "$MKFS_F2FS_PROG" = "" ] && _fatal "mkfs.f2fs not found"
+	 ;;
     nfs)
 	 ;;
     cifs)
@@ -598,6 +601,9 @@ _scratch_mkfs()
     tmpfs)
 	# do nothing for tmpfs
 	;;
+    f2fs)
+        $MKFS_F2FS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
+	;;
     *)
 	yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
 	;;
-- 
2.1.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-22 22:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1401717572-21731-1-git-send-email-jaegeuk@kernel.org>
2014-12-22 18:45 ` [PATCH] xfstests: f2fs support Eric Sandeen
2014-12-22 21:35   ` Dave Chinner
2014-12-22 22:29     ` Jaegeuk Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox