* [PATCH] xfs/077: fix test for userspace meta_uuid support
@ 2015-08-20 20:14 Eric Sandeen
0 siblings, 0 replies; only message in thread
From: Eric Sandeen @ 2015-08-20 20:14 UTC (permalink / raw)
To: fstests@vger.kernel.org
The current _require_meta_uuid() test looks for a failure return
code from xfs_db -x -c "uuid generate" but in fact this exits
with success. (In fact uuid_f always exits with success; perhaps
this needs fixing, but that's in the wild now).
So grep for the string(s) stating that it failed, instead.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/common/rc b/common/rc
index 70d2fa8..737a701 100644
--- a/common/rc
+++ b/common/rc
@@ -2720,8 +2720,11 @@ _require_meta_uuid()
# This will create a crc fs on $SCRATCH_DEV
_require_xfs_crc
- $XFS_DB_PROG -x -c "uuid generate" $SCRATCH_DEV >/dev/null 2>&1 \
- || _notrun "Userspace doesn't support meta_uuid feature"
+ $XFS_DB_PROG -x -c "uuid restore" $SCRATCH_DEV 2>&1 \
+ | grep -q "invalid UUID\|supported on V5 fs" \
+ && _notrun "Userspace doesn't support meta_uuid feature"
+
+ $XFS_DB_PROG -x -c "uuid generate" $SCRATCH_DEV >/dev/null 2>&1
_scratch_mount >/dev/null 2>&1 \
|| _notrun "Kernel doesn't support meta_uuid feature"
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-08-20 20:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-20 20:14 [PATCH] xfs/077: fix test for userspace meta_uuid support Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox