[PATCH v1] generic/608: verify S_DAX is active immediately for DONTCACHE

[PATCH v1] generic/608: verify S_DAX is active immediately for DONTCACHE

[XiaoLi Feng]

From: Xiaoli Feng <xifeng@redhat.com>

After upstream linux patches(77573fa310d, 88149082bb8), if
FS_XFLAG_DAX is set, DONTCACHE is also set. So S_DAX on the file
should be active immediately once FS_XFLAG_DAX is set.

Signed-off-by: Xiaoli Feng <xifeng@redhat.com>
---
 tests/generic/608 | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/tests/generic/608 b/tests/generic/608
index dd89d91c..278fb4d1 100755
--- a/tests/generic/608
+++ b/tests/generic/608
@@ -7,6 +7,7 @@
 # the file can take effect immediately by the following steps:
 # 1) Stop all applications which are using the file.
 # 2) Do drop_caches or umount & mount cycle.
+# 3) DONTCACHE is set.
 
 seq=`basename $0`
 seqres=$RESULT_DIR/$seq
@@ -91,6 +92,20 @@ test_cycle_mount()
 	_check_s_dax $t_file 0
 }
 
+test_nocache()
+{
+	local t_file=$SCRATCH_MNT/testnocache
+
+	rm -f $t_file
+	touch $t_file
+	_check_xflag $t_file 0
+	_check_s_dax $t_file 0
+
+	$XFS_IO_PROG -c 'chattr +x' $t_file
+	_check_xflag $t_file 1
+	_check_s_dax $t_file 1
+}
+
 do_tests()
 {
 	local mount_option=$1
@@ -100,6 +115,8 @@ do_tests()
 
 	test_drop_caches
 
+	test_nocache
+
 	test_cycle_mount "$cycle_mount_option"
 
 	_scratch_unmount
-- 
2.18.1

Re: [PATCH v1] generic/608: verify S_DAX is active immediately for DONTCACHE

[Xiao Yang]

Hi XiaoLi,

I prefer to update the existing tests because both writing drop_caches
and remount are unnecessary since Li Hao's patches.
test_drop_caches --> test_drop_cache
test_cycle_mount --> test_nocache

The detail of test_drop_cache:
-------------------------------
test_caches()
{
local t_file=$SCRATCH_MNT/testfile

rm -f $t_file
touch $t_file
_check_xflag $t_file 0
_check_s_dax $t_file 0

exec 3< $t_file

$XFS_IO_PROG -c 'chattr +x' $t_file
_check_xflag $t_file 1
_check_s_dax $t_file 0

# One application is using test file and check if S_DAX on
# the file doesn't take effect immediately
_check_s_dax $t_file 0

exec 3<&-

# No application is using test file and check if S_DAX on
# the file takes effect immediately
_check_s_dax $t_file 1
}
-------------------------------

Best Regards,
Xiao Yang
On 2021/2/5 22:17, XiaoLi Feng wrote:
> From: Xiaoli Feng <xifeng@redhat.com>
>
> After upstream linux patches(77573fa310d, 88149082bb8), if
> FS_XFLAG_DAX is set, DONTCACHE is also set. So S_DAX on the file
> should be active immediately once FS_XFLAG_DAX is set.
>
> Signed-off-by: Xiaoli Feng <xifeng@redhat.com>
> ---
>  tests/generic/608 | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/tests/generic/608 b/tests/generic/608
> index dd89d91c..278fb4d1 100755
> --- a/tests/generic/608
> +++ b/tests/generic/608
> @@ -7,6 +7,7 @@
>  # the file can take effect immediately by the following steps:
>  # 1) Stop all applications which are using the file.
>  # 2) Do drop_caches or umount & mount cycle.
> +# 3) DONTCACHE is set.
>  
>  seq=`basename $0`
>  seqres=$RESULT_DIR/$seq
> @@ -91,6 +92,20 @@ test_cycle_mount()
>  	_check_s_dax $t_file 0
>  }
>  
> +test_nocache()
> +{
> +	local t_file=$SCRATCH_MNT/testnocache
> +
> +	rm -f $t_file
> +	touch $t_file
> +	_check_xflag $t_file 0
> +	_check_s_dax $t_file 0
> +
> +	$XFS_IO_PROG -c 'chattr +x' $t_file
> +	_check_xflag $t_file 1
> +	_check_s_dax $t_file 1
> +}
> +
>  do_tests()
>  {
>  	local mount_option=$1
> @@ -100,6 +115,8 @@ do_tests()
>  
>  	test_drop_caches
>  
> +	test_nocache
> +
>  	test_cycle_mount "$cycle_mount_option"
>  
>  	_scratch_unmount

Re: [PATCH v1] generic/608: verify S_DAX is active immediately for DONTCACHE

[Xiaoli Feng]

Thanks for reviewing. I will update it.

----- Original Message -----
> From: "Xiao Yang" <yangx.jy@cn.fujitsu.com>
> To: "XiaoLi Feng" <xifeng@redhat.com>
> Cc: fstests@vger.kernel.org, "darrick wong" <darrick.wong@oracle.com>
> Sent: Monday, February 8, 2021 9:27:17 AM
> Subject: Re: [PATCH v1] generic/608: verify S_DAX is active immediately for DONTCACHE
> 
> Hi XiaoLi,
> 
> I prefer to update the existing tests because both writing drop_caches
> and remount are unnecessary since Li Hao's patches.
> test_drop_caches --> test_drop_cache
> test_cycle_mount --> test_nocache
> 
> The detail of test_drop_cache:
> -------------------------------
> test_caches()
> {
> local t_file=$SCRATCH_MNT/testfile
> 
> rm -f $t_file
> touch $t_file
> _check_xflag $t_file 0
> _check_s_dax $t_file 0
> 
> exec 3< $t_file
> 
> $XFS_IO_PROG -c 'chattr +x' $t_file
> _check_xflag $t_file 1
> _check_s_dax $t_file 0
> 
> # One application is using test file and check if S_DAX on
> # the file doesn't take effect immediately
> _check_s_dax $t_file 0
> 
> exec 3<&-
> 
> # No application is using test file and check if S_DAX on
> # the file takes effect immediately
> _check_s_dax $t_file 1
> }
> -------------------------------
> 
> Best Regards,
> Xiao Yang
> On 2021/2/5 22:17, XiaoLi Feng wrote:
> > From: Xiaoli Feng <xifeng@redhat.com>
> >
> > After upstream linux patches(77573fa310d, 88149082bb8), if
> > FS_XFLAG_DAX is set, DONTCACHE is also set. So S_DAX on the file
> > should be active immediately once FS_XFLAG_DAX is set.
> >
> > Signed-off-by: Xiaoli Feng <xifeng@redhat.com>
> > ---
> >  tests/generic/608 | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/tests/generic/608 b/tests/generic/608
> > index dd89d91c..278fb4d1 100755
> > --- a/tests/generic/608
> > +++ b/tests/generic/608
> > @@ -7,6 +7,7 @@
> >  # the file can take effect immediately by the following steps:
> >  # 1) Stop all applications which are using the file.
> >  # 2) Do drop_caches or umount & mount cycle.
> > +# 3) DONTCACHE is set.
> >  
> >  seq=`basename $0`
> >  seqres=$RESULT_DIR/$seq
> > @@ -91,6 +92,20 @@ test_cycle_mount()
> >  	_check_s_dax $t_file 0
> >  }
> >  
> > +test_nocache()
> > +{
> > +	local t_file=$SCRATCH_MNT/testnocache
> > +
> > +	rm -f $t_file
> > +	touch $t_file
> > +	_check_xflag $t_file 0
> > +	_check_s_dax $t_file 0
> > +
> > +	$XFS_IO_PROG -c 'chattr +x' $t_file
> > +	_check_xflag $t_file 1
> > +	_check_s_dax $t_file 1
> > +}
> > +
> >  do_tests()
> >  {
> >  	local mount_option=$1
> > @@ -100,6 +115,8 @@ do_tests()
> >  
> >  	test_drop_caches
> >  
> > +	test_nocache
> > +
> >  	test_cycle_mount "$cycle_mount_option"
> >  
> >  	_scratch_unmount
> 
> 
> 
>