* [PATCH] btrfs/286: add missing calls to _scratch_dev_pool_put and _spare_dev_put
@ 2023-03-07 11:38 fdmanana
2023-03-08 8:05 ` Anand Jain
0 siblings, 1 reply; 2+ messages in thread
From: fdmanana @ 2023-03-07 11:38 UTC (permalink / raw)
To: fstests; +Cc: linux-btrfs, Filipe Manana
From: Filipe Manana <fdmanana@suse.com>
The test is doing a _scratch_dev_pool_get, which shrinks the list of
devices in SCRATCH_DEV_POOL, but it's not calling _scratch_dev_pool_put
before it finishes. This will result in subsequent tests (none at the
moment however) getting a reduced list of devices in SCRATCH_DEV_POOL.
The same goes for the spare device, the test calls _spare_dev_get but
it never calls _spare_dev_put.
So add the missing calls.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
tests/btrfs/286 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/btrfs/286 b/tests/btrfs/286
index fb805256..f1ee129c 100755
--- a/tests/btrfs/286
+++ b/tests/btrfs/286
@@ -71,6 +71,9 @@ for t in "${_btrfs_profile_configs[@]}"; do
workload "$t"
done
+_spare_dev_put
+_scratch_dev_pool_put
+
echo "Silence is golden"
# success, all done
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] btrfs/286: add missing calls to _scratch_dev_pool_put and _spare_dev_put
2023-03-07 11:38 [PATCH] btrfs/286: add missing calls to _scratch_dev_pool_put and _spare_dev_put fdmanana
@ 2023-03-08 8:05 ` Anand Jain
0 siblings, 0 replies; 2+ messages in thread
From: Anand Jain @ 2023-03-08 8:05 UTC (permalink / raw)
To: fdmanana, fstests; +Cc: linux-btrfs, Filipe Manana
On 07/03/2023 19:38, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> The test is doing a _scratch_dev_pool_get, which shrinks the list of
> devices in SCRATCH_DEV_POOL, but it's not calling _scratch_dev_pool_put
> before it finishes. This will result in subsequent tests (none at the
> moment however) getting a reduced list of devices in SCRATCH_DEV_POOL.
>
> The same goes for the spare device, the test calls _spare_dev_get but
> it never calls _spare_dev_put.
>
> So add the missing calls.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---
> tests/btrfs/286 | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/btrfs/286 b/tests/btrfs/286
> index fb805256..f1ee129c 100755
> --- a/tests/btrfs/286
> +++ b/tests/btrfs/286
> @@ -71,6 +71,9 @@ for t in "${_btrfs_profile_configs[@]}"; do
> workload "$t"
> done
>
> +_spare_dev_put
> +_scratch_dev_pool_put
> +
> echo "Silence is golden"
>
> # success, all done
Looks good.
Reviewed-by: Anand Jain <anand.jain@oracle.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-08 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-07 11:38 [PATCH] btrfs/286: add missing calls to _scratch_dev_pool_put and _spare_dev_put fdmanana
2023-03-08 8:05 ` Anand Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox