FS/XFS testing framework
 help / color / mirror / Atom feed
From: Mark Harmstone <maharmstone@meta.com>
To: "fstests@vger.kernel.org" <fstests@vger.kernel.org>
Cc: "zlang@kernel.org" <zlang@kernel.org>
Subject: Re: [PATCH] common/fail_make_request: fix error message
Date: Thu, 10 Oct 2024 15:27:21 +0000	[thread overview]
Message-ID: <6c9f65d3-066a-4eb8-a2f8-a032f1fa4aa7@meta.com> (raw)
In-Reply-To: <20240731114150.2259760-1-maharmstone@fb.com>

Would someone mind accepting this patch please? This incorrect error 
message keeps tripping me up whenever I'm trying to configure a kernel 
to work with fstests.

Thanks

On 31/7/24 12:41, Mark Harmstone wrote:
> fail_make_request depends on the kernel option CONFIG_FAIL_MAKE_REQUEST
> to function, not CONFIG_FAULT_INJECTION_DEBUG_FS.
> 
> Signed-off-by: Mark Harmstone <maharmstone@fb.com>
> ---
>   common/fail_make_request | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/fail_make_request b/common/fail_make_request
> index b5370ba6..56402021 100644
> --- a/common/fail_make_request
> +++ b/common/fail_make_request
> @@ -7,7 +7,7 @@ _require_fail_make_request()
>   {
>       [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \
>   	|| _notrun "$DEBUGFS_MNT/fail_make_request \
> - not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled"
> + not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled"
>   }
>   
>   _allow_fail_make_request()


  reply	other threads:[~2024-10-10 15:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 11:41 [PATCH] common/fail_make_request: fix error message Mark Harmstone
2024-10-10 15:27 ` Mark Harmstone [this message]
2024-10-11  5:39 ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c9f65d3-066a-4eb8-a2f8-a032f1fa4aa7@meta.com \
    --to=maharmstone@meta.com \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox