* [PATCH] common/fail_make_request: fix error message
@ 2024-07-31 11:41 Mark Harmstone
2024-10-10 15:27 ` Mark Harmstone
2024-10-11 5:39 ` Zorro Lang
0 siblings, 2 replies; 3+ messages in thread
From: Mark Harmstone @ 2024-07-31 11:41 UTC (permalink / raw)
To: fstests; +Cc: Mark Harmstone
fail_make_request depends on the kernel option CONFIG_FAIL_MAKE_REQUEST
to function, not CONFIG_FAULT_INJECTION_DEBUG_FS.
Signed-off-by: Mark Harmstone <maharmstone@fb.com>
---
common/fail_make_request | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/fail_make_request b/common/fail_make_request
index b5370ba6..56402021 100644
--- a/common/fail_make_request
+++ b/common/fail_make_request
@@ -7,7 +7,7 @@ _require_fail_make_request()
{
[ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \
|| _notrun "$DEBUGFS_MNT/fail_make_request \
- not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled"
+ not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled"
}
_allow_fail_make_request()
--
2.44.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] common/fail_make_request: fix error message
2024-07-31 11:41 [PATCH] common/fail_make_request: fix error message Mark Harmstone
@ 2024-10-10 15:27 ` Mark Harmstone
2024-10-11 5:39 ` Zorro Lang
1 sibling, 0 replies; 3+ messages in thread
From: Mark Harmstone @ 2024-10-10 15:27 UTC (permalink / raw)
To: fstests@vger.kernel.org; +Cc: zlang@kernel.org
Would someone mind accepting this patch please? This incorrect error
message keeps tripping me up whenever I'm trying to configure a kernel
to work with fstests.
Thanks
On 31/7/24 12:41, Mark Harmstone wrote:
> fail_make_request depends on the kernel option CONFIG_FAIL_MAKE_REQUEST
> to function, not CONFIG_FAULT_INJECTION_DEBUG_FS.
>
> Signed-off-by: Mark Harmstone <maharmstone@fb.com>
> ---
> common/fail_make_request | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/fail_make_request b/common/fail_make_request
> index b5370ba6..56402021 100644
> --- a/common/fail_make_request
> +++ b/common/fail_make_request
> @@ -7,7 +7,7 @@ _require_fail_make_request()
> {
> [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \
> || _notrun "$DEBUGFS_MNT/fail_make_request \
> - not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled"
> + not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled"
> }
>
> _allow_fail_make_request()
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] common/fail_make_request: fix error message
2024-07-31 11:41 [PATCH] common/fail_make_request: fix error message Mark Harmstone
2024-10-10 15:27 ` Mark Harmstone
@ 2024-10-11 5:39 ` Zorro Lang
1 sibling, 0 replies; 3+ messages in thread
From: Zorro Lang @ 2024-10-11 5:39 UTC (permalink / raw)
To: Mark Harmstone; +Cc: fstests
On Wed, Jul 31, 2024 at 12:41:33PM +0100, Mark Harmstone wrote:
> fail_make_request depends on the kernel option CONFIG_FAIL_MAKE_REQUEST
> to function, not CONFIG_FAULT_INJECTION_DEBUG_FS.
>
> Signed-off-by: Mark Harmstone <maharmstone@fb.com>
> ---
Make sense to me. Maybe it want to write CONFIG_FAULT_INJECTION, anyway,
Reviewed-by: Zorro Lang <zlang@redhat.com>
> common/fail_make_request | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/fail_make_request b/common/fail_make_request
> index b5370ba6..56402021 100644
> --- a/common/fail_make_request
> +++ b/common/fail_make_request
> @@ -7,7 +7,7 @@ _require_fail_make_request()
> {
> [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \
> || _notrun "$DEBUGFS_MNT/fail_make_request \
> - not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled"
> + not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled"
> }
>
> _allow_fail_make_request()
> --
> 2.44.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-11 5:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31 11:41 [PATCH] common/fail_make_request: fix error message Mark Harmstone
2024-10-10 15:27 ` Mark Harmstone
2024-10-11 5:39 ` Zorro Lang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox