fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: fstests@vger.kernel.org
Subject: Re: [PATCH 3/5] Add _require_chown as needed
Date: Thu, 27 Aug 2026 10:17:51 -0500	[thread overview]
Message-ID: <769954e6-20b4-4100-8c6c-99286993185d@redhat.com> (raw)
In-Reply-To: <apBHC5UVZYiHZzbw@zlang-mailbox>

On 8/27/26 10:14 AM, Zorro Lang wrote:
> On Wed, Aug 26, 2026 at 02:56:42PM -0500, Eric Sandeen wrote:
>> On 8/26/26 12:52 PM, Zorro Lang wrote:
>>> On Mon, Aug 24, 2026 at 07:11:10PM -0500, Eric Sandeen wrote:
>>>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>>>> ---
>>> I doubt there's any filesystem that supports `chmod` but not `chown`.
>>>
>>> Reviewed-by: Zorro Lang <zlang@kernel.org>
>>
>> Yep, I'm not sure why we have both helpers, tbh ...
>>
>> hey, you asked for ful _requirel annotation so .... ;)
> 
> Haha, I just wanted to add the same _require_ to patches that were
> copy-pasted from the same template. I wasn't planning on updating all
> cases across the fstests. Generally, for test cases that are already
> merged, we usually don't add extra _require checks unless there's an
> obvious failure. Anyway, since you've already gone through and updated
> everything, the current changes look good to me:)
Ok, I will leave it up to you whether you want this series, or the
trivial targeted patch I sent first, which is the only one addressing
an observed problem. :)

-Eric


  reply	other threads:[~2026-08-27 15:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  0:11 [PATCH 0/5] Add many missing _requires Eric Sandeen
2026-08-25  0:11 ` [PATCH 1/5] generic: remove chmod of $seqres.full file Eric Sandeen
2026-08-26 15:15   ` Zorro Lang
2026-08-25  0:11 ` [PATCH 2/5] Add _require_chmod as needed Eric Sandeen
2026-08-26 16:09   ` Zorro Lang
2026-08-25  0:11 ` [PATCH 3/5] Add _require_chown " Eric Sandeen
2026-08-26 17:52   ` Zorro Lang
2026-08-26 19:56     ` Eric Sandeen
2026-08-27 15:14       ` Zorro Lang
2026-08-27 15:17         ` Eric Sandeen [this message]
2026-08-25  0:11 ` [PATCH 4/5] Add _require_hardlinks " Eric Sandeen
2026-08-27 15:17   ` Zorro Lang
2026-08-25  0:11 ` [PATCH 5/5] Add _require_mknod " Eric Sandeen
2026-08-27 15:19   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=769954e6-20b4-4100-8c6c-99286993185d@redhat.com \
    --to=sandeen@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).