FS/XFS testing framework
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@kernel.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/5] generic: remove chmod of $seqres.full file
Date: Wed, 26 Aug 2026 23:15:01 +0800	[thread overview]
Message-ID: <ao8C0KyuizVTgQzH@zlang-mailbox> (raw)
In-Reply-To: <20260825001337.449670-2-sandeen@redhat.com>

On Mon, Aug 24, 2026 at 07:11:08PM -0500, Eric Sandeen wrote:
> This appears to be an historical artifact.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---

Makes sense,

Reviewed-by: Zorro Lang <zlang@kernel.org>

>  tests/generic/379 | 3 ---
>  tests/generic/384 | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/tests/generic/379 b/tests/generic/379
> index 4c7fc939..9e5889b9 100755
> --- a/tests/generic/379
> +++ b/tests/generic/379
> @@ -22,9 +22,6 @@ _cleanup()
>  }
>  
>  
> -cp /dev/null $seqres.full
> -chmod ugo+rwx $seqres.full
> -
>  _require_scratch
>  _require_quota
>  _require_xfs_quota_foreign
> diff --git a/tests/generic/384 b/tests/generic/384
> index f2344380..69fe3695 100755
> --- a/tests/generic/384
> +++ b/tests/generic/384
> @@ -42,9 +42,6 @@ cat >$tmp.projid <<EOF
>  test:1
>  EOF
>  
> -cp /dev/null $seqres.full
> -chmod a+rwx $seqres.full	# arbitrary users will write here
> -
>  _require_scratch
>  _scratch_mkfs >/dev/null 2>&1
>  _scratch_enable_pquota
> -- 
> 2.55.0
> 
> 

  reply	other threads:[~2026-08-26 15:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  0:11 [PATCH 0/5] Add many missing _requires Eric Sandeen
2026-08-25  0:11 ` [PATCH 1/5] generic: remove chmod of $seqres.full file Eric Sandeen
2026-08-26 15:15   ` Zorro Lang [this message]
2026-08-25  0:11 ` [PATCH 2/5] Add _require_chmod as needed Eric Sandeen
2026-08-26 16:09   ` Zorro Lang
2026-08-25  0:11 ` [PATCH 3/5] Add _require_chown " Eric Sandeen
2026-08-26 17:52   ` Zorro Lang
2026-08-26 19:56     ` Eric Sandeen
2026-08-27 15:14       ` Zorro Lang
2026-08-27 15:17         ` Eric Sandeen
2026-08-25  0:11 ` [PATCH 4/5] Add _require_hardlinks " Eric Sandeen
2026-08-27 15:17   ` Zorro Lang
2026-08-25  0:11 ` [PATCH 5/5] Add _require_mknod " Eric Sandeen
2026-08-27 15:19   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao8C0KyuizVTgQzH@zlang-mailbox \
    --to=zlang@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox