public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] encrypt: add ceph support
@ 2022-10-31  8:38 xiubli
  2022-10-31 15:04 ` Zorro Lang
  0 siblings, 1 reply; 3+ messages in thread
From: xiubli @ 2022-10-31  8:38 UTC (permalink / raw)
  To: fstests
  Cc: zlang, david, djwong, lhenriques, ceph-devel, jlayton, mchangir,
	Xiubo Li

From: Xiubo Li <xiubli@redhat.com>

This will enable ceph could run the fscrypt test cases, but not all.
Some of them will be skipped because of not supporting features.

Here will just skip ceph in _scratch_mkfs_encrypted() and in
_require_scratch_encryption() it will try to check "set_encpolicy"
to make sure whether kernel ceph support the encryption or not.

Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---

V3:
- Add more commit comments.


 common/encrypt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/encrypt b/common/encrypt
index 45ce0954..1a77e23b 100644
--- a/common/encrypt
+++ b/common/encrypt
@@ -153,6 +153,9 @@ _scratch_mkfs_encrypted()
 		# erase the UBI volume; reformated automatically on next mount
 		$UBIUPDATEVOL_PROG ${SCRATCH_DEV} -t
 		;;
+	ceph)
+		_scratch_cleanup_files
+		;;
 	*)
 		_notrun "No encryption support for $FSTYP"
 		;;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] encrypt: add ceph support
  2022-10-31  8:38 [PATCH v3] encrypt: add ceph support xiubli
@ 2022-10-31 15:04 ` Zorro Lang
  2022-11-01  1:51   ` Xiubo Li
  0 siblings, 1 reply; 3+ messages in thread
From: Zorro Lang @ 2022-10-31 15:04 UTC (permalink / raw)
  To: xiubli; +Cc: fstests

On Mon, Oct 31, 2022 at 04:38:19PM +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
> 
> This will enable ceph could run the fscrypt test cases, but not all.
> Some of them will be skipped because of not supporting features.
> 
> Here will just skip ceph in _scratch_mkfs_encrypted() and in
> _require_scratch_encryption() it will try to check "set_encpolicy"
> to make sure whether kernel ceph support the encryption or not.
> 
> Reviewed-by: Zorro Lang <zlang@redhat.com>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> 
> V3:
> - Add more commit comments.

V2 patch has been merged and pushed.

Thanks,
Zorro

> 
> 
>  common/encrypt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/common/encrypt b/common/encrypt
> index 45ce0954..1a77e23b 100644
> --- a/common/encrypt
> +++ b/common/encrypt
> @@ -153,6 +153,9 @@ _scratch_mkfs_encrypted()
>  		# erase the UBI volume; reformated automatically on next mount
>  		$UBIUPDATEVOL_PROG ${SCRATCH_DEV} -t
>  		;;
> +	ceph)
> +		_scratch_cleanup_files
> +		;;
>  	*)
>  		_notrun "No encryption support for $FSTYP"
>  		;;
> -- 
> 2.31.1
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] encrypt: add ceph support
  2022-10-31 15:04 ` Zorro Lang
@ 2022-11-01  1:51   ` Xiubo Li
  0 siblings, 0 replies; 3+ messages in thread
From: Xiubo Li @ 2022-11-01  1:51 UTC (permalink / raw)
  To: Zorro Lang; +Cc: fstests


On 31/10/2022 23:04, Zorro Lang wrote:
> On Mon, Oct 31, 2022 at 04:38:19PM +0800, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> This will enable ceph could run the fscrypt test cases, but not all.
>> Some of them will be skipped because of not supporting features.
>>
>> Here will just skip ceph in _scratch_mkfs_encrypted() and in
>> _require_scratch_encryption() it will try to check "set_encpolicy"
>> to make sure whether kernel ceph support the encryption or not.
>>
>> Reviewed-by: Zorro Lang <zlang@redhat.com>
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>>
>> V3:
>> - Add more commit comments.
> V2 patch has been merged and pushed.

Ah Okay.

Sorry, I pulled it and didn't see that yesterday.

I may missed that.

Thanks Zorro!


> Thanks,
> Zorro
>
>>
>>   common/encrypt | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/common/encrypt b/common/encrypt
>> index 45ce0954..1a77e23b 100644
>> --- a/common/encrypt
>> +++ b/common/encrypt
>> @@ -153,6 +153,9 @@ _scratch_mkfs_encrypted()
>>   		# erase the UBI volume; reformated automatically on next mount
>>   		$UBIUPDATEVOL_PROG ${SCRATCH_DEV} -t
>>   		;;
>> +	ceph)
>> +		_scratch_cleanup_files
>> +		;;
>>   	*)
>>   		_notrun "No encryption support for $FSTYP"
>>   		;;
>> -- 
>> 2.31.1
>>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-01  1:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-31  8:38 [PATCH v3] encrypt: add ceph support xiubli
2022-10-31 15:04 ` Zorro Lang
2022-11-01  1:51   ` Xiubo Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox