* [PATCH] fstests: test for fallocate capability in more tests
@ 2020-04-09 20:06 Eric Sandeen
2020-04-09 20:49 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2020-04-09 20:06 UTC (permalink / raw)
To: fstests, Namjae Jeon
These 3 tests explicitly call xfs_io's fallocate command, test whether
it works before running the test.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tests/generic/286 b/tests/generic/286
index 00cb87b7..8be4fbc9 100755
--- a/tests/generic/286
+++ b/tests/generic/286
@@ -23,6 +23,7 @@ _supported_fs generic
_supported_os Linux
_require_test
+_require_xfs_io_command "falloc"
_require_seek_data_hole
src=$TEST_DIR/seek_copy_testfile
diff --git a/tests/generic/404 b/tests/generic/404
index 14decdb7..69d7e71e 100755
--- a/tests/generic/404
+++ b/tests/generic/404
@@ -76,6 +76,7 @@ rm -f $seqres.full
_supported_fs generic
_supported_os Linux
_require_test
+_require_xfs_io_command "falloc"
_require_xfs_io_command "finsert"
blksize=`_get_block_size $TEST_DIR`
diff --git a/tests/generic/569 b/tests/generic/569
index 4573be5a..385fa59f 100755
--- a/tests/generic/569
+++ b/tests/generic/569
@@ -29,6 +29,7 @@ _cleanup()
# real QA test starts here
_supported_os Linux
_supported_fs generic
+_require_xfs_io_command "falloc"
_require_test_program swapon
_require_scratch_swapfile
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fstests: test for fallocate capability in more tests
2020-04-09 20:06 [PATCH] fstests: test for fallocate capability in more tests Eric Sandeen
@ 2020-04-09 20:49 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-04-09 20:49 UTC (permalink / raw)
To: Eric Sandeen; +Cc: fstests, Namjae Jeon
On Thu, Apr 09, 2020 at 03:06:28PM -0500, Eric Sandeen wrote:
> These 3 tests explicitly call xfs_io's fallocate command, test whether
> it works before running the test.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/tests/generic/286 b/tests/generic/286
> index 00cb87b7..8be4fbc9 100755
> --- a/tests/generic/286
> +++ b/tests/generic/286
> @@ -23,6 +23,7 @@ _supported_fs generic
> _supported_os Linux
>
> _require_test
> +_require_xfs_io_command "falloc"
> _require_seek_data_hole
>
> src=$TEST_DIR/seek_copy_testfile
> diff --git a/tests/generic/404 b/tests/generic/404
> index 14decdb7..69d7e71e 100755
> --- a/tests/generic/404
> +++ b/tests/generic/404
> @@ -76,6 +76,7 @@ rm -f $seqres.full
> _supported_fs generic
> _supported_os Linux
> _require_test
> +_require_xfs_io_command "falloc"
> _require_xfs_io_command "finsert"
>
> blksize=`_get_block_size $TEST_DIR`
> diff --git a/tests/generic/569 b/tests/generic/569
> index 4573be5a..385fa59f 100755
> --- a/tests/generic/569
> +++ b/tests/generic/569
> @@ -29,6 +29,7 @@ _cleanup()
> # real QA test starts here
> _supported_os Linux
> _supported_fs generic
> +_require_xfs_io_command "falloc"
> _require_test_program swapon
> _require_scratch_swapfile
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-09 20:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-09 20:06 [PATCH] fstests: test for fallocate capability in more tests Eric Sandeen
2020-04-09 20:49 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox