public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fstests: skip btrfs/254 in case MIN_FSSIZE is more than 1G
@ 2022-11-28 12:51 Johannes Thumshirn
  2022-11-28 16:03 ` Josef Bacik
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Thumshirn @ 2022-11-28 12:51 UTC (permalink / raw)
  To: Zorro Lang; +Cc: Johannes Thumshirn, linux-btrfs, fstests

The test-case btrfs/254 creates a 1G device-mapper setup, but this might
be too small for the filesystem to actually operate (i.e. in case of a
zoned block device which needs at least 5 zones).

Skip the test if MIN_FSSIZE is set to a value above 1G.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 tests/btrfs/254 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/btrfs/254 b/tests/btrfs/254
index 5d6e33f40bb5..ae55ae8ca3a2 100755
--- a/tests/btrfs/254
+++ b/tests/btrfs/254
@@ -40,6 +40,7 @@ _require_dm_target linear
 _require_btrfs_forget_or_module_loadable
 _require_scratch_nocheck
 _require_command "$WIPEFS_PROG" wipefs
+_check_minimal_fs_size $((1024 * 1024 * 1024))
 
 _scratch_dev_pool_get 3
 
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fstests: skip btrfs/254 in case MIN_FSSIZE is more than 1G
  2022-11-28 12:51 [PATCH] fstests: skip btrfs/254 in case MIN_FSSIZE is more than 1G Johannes Thumshirn
@ 2022-11-28 16:03 ` Josef Bacik
  0 siblings, 0 replies; 2+ messages in thread
From: Josef Bacik @ 2022-11-28 16:03 UTC (permalink / raw)
  To: Johannes Thumshirn; +Cc: Zorro Lang, linux-btrfs, fstests

On Mon, Nov 28, 2022 at 04:51:05AM -0800, Johannes Thumshirn wrote:
> The test-case btrfs/254 creates a 1G device-mapper setup, but this might
> be too small for the filesystem to actually operate (i.e. in case of a
> zoned block device which needs at least 5 zones).
> 
> Skip the test if MIN_FSSIZE is set to a value above 1G.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-28 16:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-28 12:51 [PATCH] fstests: skip btrfs/254 in case MIN_FSSIZE is more than 1G Johannes Thumshirn
2022-11-28 16:03 ` Josef Bacik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox