[PATCH] xfs/440: skip test if the dax mount option is enabled

[PATCH] xfs/440: skip test if the dax mount option is enabled

[Xiao Yang]

With the enabled dax mount option, this test doesn't
work well because unwritten extents will not be allocated
according to the CoW extent size hint.

Try to fix the following error by the patch:
$./check xfs/440
    ...
     fsgqa 64 0 0
     Reflink and CoW
     root 0 0 0
    -fsgqa 1152 0 0
    +fsgqa 128 0 0
     Sync
     root 0 0 0
    ...

Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
 tests/xfs/440 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/xfs/440 b/tests/xfs/440
index 496ee04e..eb9fbd73 100755
--- a/tests/xfs/440
+++ b/tests/xfs/440
@@ -23,6 +23,7 @@ _require_quota
 _require_scratch_reflink
 _require_cp_reflink
 _require_user
+_exclude_scratch_mount_option dax
 
 echo "Format and mount"
 _scratch_mkfs > "$seqres.full" 2>&1
-- 
2.25.1

RE: [PATCH] xfs/440: skip test if the dax mount option is enabled

[yangx.jy]

Hi Darrick,

Is there any comment on the patch?

Best Regards,
Xiao Yang

-----Original Message-----
From: Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com> 
Sent: 2022年12月23日 18:22
To: djwong@kernel.org; fstests@vger.kernel.org
Cc: zlang@kernel.org; Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com>
Subject: [PATCH] xfs/440: skip test if the dax mount option is enabled

With the enabled dax mount option, this test doesn't work well because unwritten extents will not be allocated according to the CoW extent size hint.

Try to fix the following error by the patch:
$./check xfs/440
    ...
     fsgqa 64 0 0
     Reflink and CoW
     root 0 0 0
    -fsgqa 1152 0 0
    +fsgqa 128 0 0
     Sync
     root 0 0 0
    ...

Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
 tests/xfs/440 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/xfs/440 b/tests/xfs/440 index 496ee04e..eb9fbd73 100755
--- a/tests/xfs/440
+++ b/tests/xfs/440
@@ -23,6 +23,7 @@ _require_quota
 _require_scratch_reflink
 _require_cp_reflink
 _require_user
+_exclude_scratch_mount_option dax
 
 echo "Format and mount"
 _scratch_mkfs > "$seqres.full" 2>&1
--
2.25.1

Re: [PATCH] xfs/440: skip test if the dax mount option is enabled

[Darrick J. Wong]

On Fri, Jan 13, 2023 at 04:53:41AM +0000, yangx.jy@fujitsu.com wrote:
> Hi Darrick,
> 
> Is there any comment on the patch?

What happens if you set DAXINHERIT on the root directory and omit the
mount options?  Does it still fail?

--D


> Best Regards,
> Xiao Yang
> 
> -----Original Message-----
> From: Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com> 
> Sent: 2022年12月23日 18:22
> To: djwong@kernel.org; fstests@vger.kernel.org
> Cc: zlang@kernel.org; Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com>
> Subject: [PATCH] xfs/440: skip test if the dax mount option is enabled
> 
> With the enabled dax mount option, this test doesn't work well because unwritten extents will not be allocated according to the CoW extent size hint.
> 
> Try to fix the following error by the patch:
> $./check xfs/440
>     ...
>      fsgqa 64 0 0
>      Reflink and CoW
>      root 0 0 0
>     -fsgqa 1152 0 0
>     +fsgqa 128 0 0
>      Sync
>      root 0 0 0
>     ...
> 
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
> ---
>  tests/xfs/440 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/xfs/440 b/tests/xfs/440 index 496ee04e..eb9fbd73 100755
> --- a/tests/xfs/440
> +++ b/tests/xfs/440
> @@ -23,6 +23,7 @@ _require_quota
>  _require_scratch_reflink
>  _require_cp_reflink
>  _require_user
> +_exclude_scratch_mount_option dax
>  
>  echo "Format and mount"
>  _scratch_mkfs > "$seqres.full" 2>&1
> --
> 2.25.1
> 

Re: [PATCH] xfs/440: skip test if the dax mount option is enabled

[Xiao Yang]

On 2023/1/14 5:33, Darrick J. Wong wrote:
> On Fri, Jan 13, 2023 at 04:53:41AM +0000,yangx.jy@fujitsu.com  wrote:
>> Hi Darrick,
>>
>> Is there any comment on the patch?
> What happens if you set DAXINHERIT on the root directory and omit the
> mount options?  Does it still fail?
Hi Darrick,

Yes, it still failed.  I have reviewed your patch set fixing the issue.

Thanks a lot.

Best Regards,
Xiao Yang
> 
> --D
> 
> 

Re: [PATCH] xfs/440: skip test if the dax mount option is enabled

[Xiao Yang]

On 2023/1/14 5:33, Darrick J. Wong wrote:
> On Fri, Jan 13, 2023 at 04:53:41AM +0000,yangx.jy@fujitsu.com  wrote:
>> Hi Darrick,
>>
>> Is there any comment on the patch?
> What happens if you set DAXINHERIT on the root directory and omit the
> mount options?  Does it still fail?
Hi Darrick,

Yes, it still failed.  I have reviewed your patch set fixing the issue.

Thanks a lot.

Best Regards,
Xiao Yang
> 
> --D
> 
>