From: Anthony Iliopoulos <ailiop@suse.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] build: remove unused AC_PACKAGE_NEED_OPEN_BY_FSHANDLE macro
Date: Tue, 12 Oct 2021 18:19:06 +0200 [thread overview]
Message-ID: <YWW1esouYFRcbuHf@technoir> (raw)
In-Reply-To: <20211012153946.GH24282@magnolia>
On Tue, Oct 12, 2021 at 08:39:46AM -0700, Darrick J. Wong wrote:
> On Tue, Oct 12, 2021 at 03:50:57PM +0200, Anthony Iliopoulos wrote:
> > Commit 5868405dce1d ("Sync up different copies of the m4 macros, noop
> > change for this package.") introduced this macro, by the function was
> > never really used by any test, remove it.
>
> If we're not going to keep this in sync (with what I have no idea) then
> why not remove the other unused macros?
This was standing out as I was looking specifically into fstests
dependencies to libhandle, but I didn't make a full pass through the
rest. Indeed at least AC_PACKAGE_NEED_LIBXFSINIT_LIBXFS seems also
unused.
From looking at earlier commits, I think sync was referring to bringing
the m4 macros up to date with the rest of the packages (xfsprogs,
xfsdump at least). Commit c1ef92a938a1 ("Updates to QA scrdiff script to
keep package configure macros in sync.") includes the following comment:
"xfstests directory m4 directory is a repository of all of the custom
m4 macros used in the packages we look after."
I just checked xfsdump and most of the macros in package_xfslibs.m4 are
indeed unused.
Regards,
Anthony
next prev parent reply other threads:[~2021-10-12 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 13:50 [PATCH] build: remove unused AC_PACKAGE_NEED_OPEN_BY_FSHANDLE macro Anthony Iliopoulos
2021-10-12 14:28 ` David Disseldorp
2021-10-12 15:39 ` Darrick J. Wong
2021-10-12 16:19 ` Anthony Iliopoulos [this message]
2021-10-24 13:57 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWW1esouYFRcbuHf@technoir \
--to=ailiop@suse.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox