* [PATCH] generic/420: skip test for ocfs2
@ 2025-01-06 14:01 Su Yue
2025-01-06 16:31 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Su Yue @ 2025-01-06 14:01 UTC (permalink / raw)
To: fstests; +Cc: ocfs2-devel, Su Yue
ocfs2 doesn't support fallocate with
mode=FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE so skip it.
Signed-off-by: Su Yue <glass.su@suse.com>
---
tests/generic/420 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/generic/420 b/tests/generic/420
index edd9655fd3a3..e67442f8979b 100755
--- a/tests/generic/420
+++ b/tests/generic/420
@@ -15,6 +15,7 @@ _begin_fstest auto quick punch
# Modify as appropriate.
+_supported_fs ^ocfs2
_require_test
_require_xfs_io_command fpunch
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] generic/420: skip test for ocfs2
2025-01-06 14:01 [PATCH] generic/420: skip test for ocfs2 Su Yue
@ 2025-01-06 16:31 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2025-01-06 16:31 UTC (permalink / raw)
To: Su Yue; +Cc: fstests, ocfs2-devel
On Mon, Jan 06, 2025 at 10:01:31PM +0800, Su Yue wrote:
> ocfs2 doesn't support fallocate with
> mode=FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE so skip it.
>
> Signed-off-by: Su Yue <glass.su@suse.com>
> ---
> tests/generic/420 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/420 b/tests/generic/420
> index edd9655fd3a3..e67442f8979b 100755
> --- a/tests/generic/420
> +++ b/tests/generic/420
> @@ -15,6 +15,7 @@ _begin_fstest auto quick punch
>
>
> # Modify as appropriate.
> +_supported_fs ^ocfs2
> _require_test
> _require_xfs_io_command fpunch
_require_xfs_io_command should be checking for hole punch
support. If that doesn't work we'll need to fix it instead
of throwing in undocumented blacklisting of file system types.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-06 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-06 14:01 [PATCH] generic/420: skip test for ocfs2 Su Yue
2025-01-06 16:31 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox