[PATCHSET 0/2] fstests: random fixes for v2023.11.19

[PATCHSET 0/2] fstests: random fixes for v2023.11.19

[Darrick J. Wong]

Hi all,

Here's the usual odd fixes for fstests.

If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.

This has been running on the djcloud for months with no problems.  Enjoy!
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=random-fixes

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=random-fixes

fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=random-fixes
---
 tests/generic/734     |    3 ++-
 tests/generic/734.out |    2 +-
 tests/xfs/604         |    3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)
 rename tests/{xfs/601 => generic/734} (98%)
 rename tests/{xfs/601.out => generic/734.out} (78%)

[PATCH 1/2] xfs/601: move this to tests/generic

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

As per last week's discussion, xfs/601 doesn't have any xfs-specific
functionality in it.  Turn it into a generic test.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/generic/734     |    3 ++-
 tests/generic/734.out |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
 rename tests/{xfs/601 => generic/734} (98%)
 rename tests/{xfs/601.out => generic/734.out} (78%)


diff --git a/tests/xfs/601 b/tests/generic/734
similarity index 98%
rename from tests/xfs/601
rename to tests/generic/734
index 9df46e5ebe..93c2ad90e3 100755
--- a/tests/xfs/601
+++ b/tests/generic/734
@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: GPL-2.0
 # Copyright (c) 2023 Oracle.  All Rights Reserved.
 #
-# FS QA Test No. 601
+# FS QA Test No. 734
 #
 # This is a regression test for the kernel commit noted below.  The stale
 # memory exposure can be exploited by creating a file with shared blocks,
@@ -29,6 +29,7 @@ _fixed_by_git_commit kernel 35d30c9cf127 \
 	"iomap: don't skip reading in !uptodate folios when unsharing a range"
 
 # real QA test starts here
+_supported_fs generic
 _require_test_reflink
 _require_cp_reflink
 _require_xfs_io_command "funshare"
diff --git a/tests/xfs/601.out b/tests/generic/734.out
similarity index 78%
rename from tests/xfs/601.out
rename to tests/generic/734.out
index 34d519ca46..174c3f82cb 100644
--- a/tests/xfs/601.out
+++ b/tests/generic/734.out
@@ -1,4 +1,4 @@
-QA output created by 601
+QA output created by 734
 Create the original file and a clone
 Funshare at least one pagecache page
 Check contents

Re: [PATCH 1/2] xfs/601: move this to tests/generic

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

[PATCH 2/2] xfs/604: add missing falloc test

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

This test requires both the xfs_io falloc and fpunch commands to run.
falloc isn't supported on alwayscow=1 mounts, which means this test
fails there.

While we're at it, update the commit id since the fix was committed to
6.7-rc2.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/604 |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


diff --git a/tests/xfs/604 b/tests/xfs/604
index 50cdebcd50..bb6db797e5 100755
--- a/tests/xfs/604
+++ b/tests/xfs/604
@@ -13,9 +13,10 @@ _begin_fstest auto prealloc punch
 
 _supported_fs xfs
 _require_scratch
+_require_xfs_io_command "falloc"
 _require_xfs_io_command "fpunch"
 _require_test_program punch-alternating
-_fixed_by_kernel_commit XXXXXXXXXXXX "xfs: fix internal error from AGFL exhaustion"
+_fixed_by_kernel_commit f63a5b3769ad "xfs: fix internal error from AGFL exhaustion"
 
 # Disable the rmapbt so we only need to worry about splitting the bnobt and
 # cntbt at the same time.

Re: [PATCH 2/2] xfs/604: add missing falloc test

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>