* [PATCH] generic/754: fix _fixed_by tags
@ 2024-07-26 16:51 Darrick J. Wong
2024-07-26 17:14 ` Christoph Hellwig
2024-07-26 17:17 ` Zorro Lang
0 siblings, 2 replies; 3+ messages in thread
From: Darrick J. Wong @ 2024-07-26 16:51 UTC (permalink / raw)
To: Zorro Lang; +Cc: Ma Xinjian, fstests, xfs
From: Darrick J. Wong <djwong@kernel.org>
This test requires an xfs_repair patch, so note that in the test. Also
update the kernel git hash since we now have one.
Reported-by: maxj.fnst@fujitsu.com
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
tests/generic/754 | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/generic/754 b/tests/generic/754
index f73d1ed611..7afda609f5 100755
--- a/tests/generic/754
+++ b/tests/generic/754
@@ -13,9 +13,12 @@ _begin_fstest auto
_require_scratch
-test $FSTYP = "xfs" && \
- _fixed_by_git_commit kernel XXXXXXXXXXXXX \
+if [ $FSTYP = "xfs" ]; then
+ _fixed_by_git_commit kernel 38de567906d95 \
"xfs: allow symlinks with short remote targets"
+ _fixed_by_git_commit xfsprogs XXXXXXXXXXXXX \
+ "xfs_repair: small remote symlinks are ok"
+fi
_scratch_mkfs >> $seqres.full
_scratch_mount >> $seqres.full
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] generic/754: fix _fixed_by tags
2024-07-26 16:51 [PATCH] generic/754: fix _fixed_by tags Darrick J. Wong
@ 2024-07-26 17:14 ` Christoph Hellwig
2024-07-26 17:17 ` Zorro Lang
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-07-26 17:14 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Zorro Lang, Ma Xinjian, fstests, xfs
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] generic/754: fix _fixed_by tags
2024-07-26 16:51 [PATCH] generic/754: fix _fixed_by tags Darrick J. Wong
2024-07-26 17:14 ` Christoph Hellwig
@ 2024-07-26 17:17 ` Zorro Lang
1 sibling, 0 replies; 3+ messages in thread
From: Zorro Lang @ 2024-07-26 17:17 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Ma Xinjian, fstests, xfs
On Fri, Jul 26, 2024 at 09:51:07AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> This test requires an xfs_repair patch, so note that in the test. Also
> update the kernel git hash since we now have one.
>
> Reported-by: maxj.fnst@fujitsu.com
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> tests/generic/754 | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/generic/754 b/tests/generic/754
> index f73d1ed611..7afda609f5 100755
> --- a/tests/generic/754
> +++ b/tests/generic/754
> @@ -13,9 +13,12 @@ _begin_fstest auto
>
> _require_scratch
>
> -test $FSTYP = "xfs" && \
> - _fixed_by_git_commit kernel XXXXXXXXXXXXX \
> +if [ $FSTYP = "xfs" ]; then
> + _fixed_by_git_commit kernel 38de567906d95 \
> "xfs: allow symlinks with short remote targets"
> + _fixed_by_git_commit xfsprogs XXXXXXXXXXXXX \
> + "xfs_repair: small remote symlinks are ok"
Thanks for this update.
Reviewed-by: Zorro Lang <zlang@redhat.com>
> +fi
>
> _scratch_mkfs >> $seqres.full
> _scratch_mount >> $seqres.full
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-26 17:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-26 16:51 [PATCH] generic/754: fix _fixed_by tags Darrick J. Wong
2024-07-26 17:14 ` Christoph Hellwig
2024-07-26 17:17 ` Zorro Lang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox